Re: Anyone using a Jabra USB Headset with -current?

[Michael van Elst <mlelstv%serpens.de@localhost>]

On Mon, May 24, 2021 at 08:49:26AM +0300, Andrius V wrote:
> Jabra Evolve 20 is not working on NetBSD 9.2 for me (submitted pr
> 56172 recently). But yes, it does work on current branch, except that
> removing headset on audio play causes panic.

Possible. I test on -current.

Removing the headset doesn't panic for me which might be caused by:

Index: uaudio.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/uaudio.c,v
retrieving revision 1.169
diff -p -u -r1.169 uaudio.c
--- uaudio.c    15 Feb 2021 13:39:18 -0000      1.169
+++ uaudio.c    24 May 2021 08:05:05 -0000
@@ -519,7 +519,7 @@ static int
 uaudio_detach(device_t self, int flags)
 {
        struct uaudio_softc *sc = device_private(self);
-       int rv = 0;
+       int rv;
 
        sc->sc_dying = 1;
 
@@ -529,8 +529,11 @@ uaudio_detach(device_t self, int flags)
        uaudio_halt_out_dma_unlocked(sc);
        uaudio_halt_in_dma_unlocked(sc);
 
-       if (sc->sc_audiodev != NULL)
+       if (sc->sc_audiodev != NULL) {
                rv = config_detach(sc->sc_audiodev, flags);
+               if (rv)
+                       return rv;
+       }
 
        usbd_add_drv_event(USB_EVENT_DRIVER_DETACH, sc->sc_udev, sc->sc_dev);
 
@@ -541,7 +544,7 @@ uaudio_detach(device_t self, int flags)
        mutex_destroy(&sc->sc_lock);
        mutex_destroy(&sc->sc_intr_lock);
 
-       return rv;
+       return 0;
 }
 
 Static int



Greetings,
-- 
                                Michael van Elst
Internet: mlelstv%serpens.de@localhost
                                "A potential Snark may lurk in every tree."