Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: st.c update has broken dump multi-tape support



Hi Frank,

On Wed, Jun 09, 2021 at 07:06:07PM +0200, Frank Kardel wrote:
> 
> A quick analysis leaves me to believe that the culprit is in this commit:
> 
>    revision 1.234
>    date: 2018-03-24 09:08:19 +0100;  author: mlelstv;  state: Exp;
>    lines: +176 -134;  commitid: xU4Kh6YFLfDywGvA;
>    branches:  1.234.2;
>    Use separate lock to protect internal state and release locks when
>    calling biodone.
> 
> Here the logic for ST_EARLY_WARN got lost. So the EOM always delivers EIO
> instead
> 

Yes, I think you are correct looking at that change.  My backup script
does set the early warning flag.  I will have a stab at fixing this
later today, I think if I just avoid returning EIO in the ST_EOM_PENDING
case inside ststart it should be good.

-- 
Brett Lymn
--
Sent from my NetBSD device.

"We are were wolves",
"You mean werewolves?",
"No we were wolves, now we are something else entirely",
"Oh"


Home | Main Index | Thread Index | Old Index