Re: Script command under NetBSD-current

[Dave Tyson <dtyson%anduin.org.uk@localhost>]

On Tuesday 15 Jun 2021 08:15:12 RVP wrote:
> On Mon, 14 Jun 2021, Dave Tyson wrote:
> > NetBSD cruncher2.anduin.org.uk 9.99.83 NetBSD 9.99.83 (GENERIC) #2: Tue
> > Jun  8 19:42:49 GMT 2021
> > root%cruncher2.anduin.org.uk@localhost:/usr/obj/sys/arch/amd64/compile/GENERIC amd64
> > 
> > If you issue a script command, run a process with takes a little while and
> > then an exit command to close the script file and return to a command
> > prompt. viz:
> > 
> > cd /usr/pkgsrc
> > script /tmp/ll
> > cvs update -dP
> > exit
> > 
> > what happens is you don't get a command prompt - its like the script
> > command
> > freezes and doesn't return. Issuing a ps shows the script processes:
> The small patch below fixes it for me.
> 
> --- START PATCH ---
> --- libexec/ld.elf_so.orig/rtld.c	2020-09-22 00:41:27.000000000 +0000
> +++ libexec/ld.elf_so/rtld.c	2021-06-15 08:11:34.301709238 +0000
> @@ -1750,6 +1750,8 @@
>   	sigdelset(&blockmask, SIGTRAP);	/* Allow the debugger */
>   	sigprocmask(SIG_BLOCK, &blockmask, mask);
> 
> +	membar_enter();
> +
>   	for (;;) {
>   		if (atomic_cas_uint(&_rtld_mutex, 0, locked_value) == 0) {
>   			membar_enter();
> --- END PATCH ---
> 
> -RVP

Thanks for the fast response and fix. I can confirm the patch fixes the 
problem. Please can this be committed

Cheers,
Dave