Re: Pcmcia ne(4)/mii crash in -current

[Jason Thorpe <thorpej%me.com@localhost>]

> On Jun 27, 2021, at 7:40 AM, Björn Johannesson <rherdware%yahoo.com@localhost> wrote:
> 
> Hello.
> 
> Decided to try out -current/i386 on a Thinkpad A31. If I boot with, or insert,
> my ne(4) pcmcia card the kernel crashes. It works on NetBSD 9.
> The cardbus ex(4) or pcmcia wi(4) does not crash the kernel.
> I see there are some big changes in sys/dev/mii/mii.c since 9.x.
> How to proceed?

This should fix the assertion failure at attach time:

	https://www.netbsd.org/~thorpej/dp8390-assert-patch.txt

(Note: NOT compile-tested, but avoids the problematic call to mii_down() before the interface structures have been initialized.)

> 
> /Björn
> 
> Please CC if replying
> 
> Crash follows:
> [   1.0000000] NetBSD 9.99.85 (GENERIC) #0: Thu Jun 24 16:41:16 UTC 2021
> [   1.0000000]  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/i386/compile/GENERIC
> [...]
> 
> [   2.7831587] ne2 at pcmcia0 function 0: <D-Link, DFE-670TXD, PC Card>
> [   2.8596801] panic: kernel diagnostic assertion "mii_locked(mii)" failed: file "/usr/src/sys/dev/mii/mii.c", line 379 
> [   2.9844745] cpu0: Begin traceback...
> [   3.0291925] vpanic(c11949b4,d8a16db4,d8a16dcc,c0a864d6,c11949b4,c119491b,c126c3e9,c126c3bf,17b,c23fb800) at netbsd:vpanic+0x13c
> [   3.1643761] kern_assert(c11949b4,c119491b,c126c3e9,c126c3bf,17b,c23fb800,0,d8a16df4,c058f4d2,c23fba44) at netbsd:kern_assert+0x23
> [   3.3043517] mii_down(c23fba44,801,1,1,40000000,c23fb800,c14936a0,4000,d8a16e48,c05b1baa) at netbsd:mii_down+0xa5
> [   3.4266494] dp8390_config(c23fb800,4000,0,10,3,6000,4010,c14936a0,1,4000) at netbsd:dp8390_config+0xfc
> [   3.5332599] ne2000_attach(c23fb800,d8a16e72,f,10,c23fbbf4,c23c7200,c10672d0,d8a16e72,d005b17,e684088) at  netbsd:ne2000_attach+0x17b
> [   3.6831837] ne_pcmcia_attach(c2337c00,c23c7200,d8a16f30,d8a16f30,c14d0570,c23c7200,d8a16f30,c2337c00,c14d0570,d8a16ee4) at netbsd:ne_pcmcia_attach+0x331
> [   3.8441832] config_vattach(c2337c00,c14d0570,d8a16f30,c038cbdc,0,d8a16f18,0,c1065dac,c231e580,c23f7a04) at netbsd:config_vattach+0x19c
> [   3.9931868] config_vfound(c2337c00,d8a16f30,c038cbdc,0,d8a16f18,d8a16f4c,c038c726,c2337c00,d8a16f30,c038cbdc) at netbsd:config_vfound+0x54
> [   4.1431899] config_found(c2337c00,d8a16f30,c038cbdc,0,c0cdb8ad,3,d8a16f2c,eeeeeeee,c231e58c,0) at netbsd:config_found+0x2d
> [   4.2737844] pcmcia_rescan(c2337c00,0,c1065dac,c14db540,c239dd80,c239e184,c239dd80,d8a16f9c,c038232e,c2337c00) at netbsd:pcmcia_rescan+0xc2
> [   4.4231861] pcmcia_card_attach(c2337c00,d8a14000,c23296c0,c239dd98,1,c239dda0,c239dd80,c0382159,c2329980,0) at netbsd:pcmcia_card_attach+0xc4
> [   4.5733918] cardslot_event_thread(c239dd80,1760000,176b000,0,c01005a8,0,0,0,0,0) at netbsd:cardslot_event_thread+0x1d5
> [   4.7047356] cpu0: End traceback...
> [   4.7453025] fatal breakpoint trap in supervisor mode
> [   4.8045770] trap type 1 code 0 eip 0xc011acf4 cs 0x8 eflags 0x202 cr2 0 ilevel 0 esp 0xd8a16d98
> [   4.9085701] curlwp 0xc2329980 pid 0 lid 25 lowest kstack 0xd8a142c0
> Stopped in pid 0.25 (system) at netbsd:breakpoint+0x4:  popl    %ebp
> db{0}> bt
> breakpoint(c1291039,c1593e40,c11949b4,d8a16db4,c23fb800,c23fba44,d8a16da8,c0e836
> 62,c11949b4,d8a16db4) at netbsd:breakpoint+0x4
> vpanic(c11949b4,d8a16db4,d8a16dcc,c0a864d6,c11949b4,c119491b,c126c3e9,c126c3bf,1
> 7b,c23fb800) at netbsd:vpanic+0x13c
> kern_assert(c11949b4,c119491b,c126c3e9,c126c3bf,17b,c23fb800,0,d8a16df4,c058f4d2
> ,c23fba44) at netbsd:kern_assert+0x23
> mii_down(c23fba44,801,1,1,40000000,c23fb800,c14936a0,4000,d8a16e48,c05b1baa) at 
> netbsd:mii_down+0xa5
> dp8390_config(c23fb800,4000,0,10,3,6000,4010,c14936a0,1,4000) at netbsd:dp8390_c
> onfig+0xfc
> ne2000_attach(c23fb800,d8a16e72,f,10,c23fbbf4,c23c7200,c10672d0,d8a16e72,d005b17
> ,e684088) at netbsd:ne2000_attach+0x17b
> ne_pcmcia_attach(c2337c00,c23c7200,d8a16f30,d8a16f30,c14d0570,c23c7200,d8a16f30,
> c2337c00,c14d0570,d8a16ee4) at netbsd:ne_pcmcia_attach+0x331
> config_vattach(c2337c00,c14d0570,d8a16f30,c038cbdc,0,d8a16f18,0,c1065dac,c231e58
> 0,c23f7a04) at netbsd:config_vattach+0x19c
> config_vfound(c2337c00,d8a16f30,c038cbdc,0,d8a16f18,d8a16f4c,c038c726,c2337c00,d
> 8a16f30,c038cbdc) at netbsd:config_vfound+0x54
> config_found(c2337c00,d8a16f30,c038cbdc,0,c0cdb8ad,3,d8a16f2c,eeeeeeee,c231e58c,
> 0) at netbsd:config_found+0x2d
> pcmcia_rescan(c2337c00,0,c1065dac,c14db540,c239dd80,c239e184,c239dd80,d8a16f9c,c
> 038232e,c2337c00) at netbsd:pcmcia_rescan+0xc2
> pcmcia_card_attach(c2337c00,d8a14000,c23296c0,c239dd98,1,c239dda0,c239dd80,c0382
> 159,c2329980,0) at netbsd:pcmcia_card_attach+0xc4
> cardslot_event_thread(c239dd80,1760000,176b000,0,c01005a8,0,0,0,0,0) at netbsd:c
> ardslot_event_thread+0x1d5
> db{0}> 
> 

-- thorpej