Re: Compiling fails on MacOS

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Thu, 31 Oct 2024 08:58:44 +0100
    From:        Thomas Klausner <wiz%gatalith.at@localhost>
    Message-ID:  <ZyM4tO3uUQJxfOqR%exadelic.gatalith.at@localhost>

  | I just checked on NetBSD and don't see the warning, and the file
  | includes stdlib.h now like it should, so this is probably solved.

No, as Martin said, for the tools build non-std functions need to be
in libnbcompat (and the tool needs to use that) or not used at all.

Both solutions are possible here (adding shquote(3) to libnbcompat
is probably worthwhile, as there could, in the future, easily be
other tools which need it) or replacing the usage of shquote by
a private function in ctags (it is not difficult to replicate).
Or both.

There's actually a third possible solution here, which is to remove
ctags as a tool, it really has no business being one (there's no
rational reason to run it while building).   That said, I see that
we do install a /var/db/libc.tags file - which has two problems
all caused by one issue.   It contains full path names to the libc
files containing the functions it contains a reference to (which
it really needs to be useful as it is, assuming that it is that is).

But those full path names are from the build host, and contain path
names that only exist there - and even that isn't guaranteed.   That
means any build containing them isn't reproducible, and nor is the
installed file useful on the target system (unless it just happens to
install sources in the same place).   For me /usr/src contains the
sources for the system that is running (the host) whereas when I am
building the sources being compiled are elsewhere (where depends which
release is being built).   And for me, the path name used for the
sources being built is transitory even then, as I use a read-only
mounted copy to ensure that the build process doesn't touch the source
directories - as soon as the build finishes, that directory vanishes.

kre