Subject: hack Makefile brushup
To: None <netbsd-bugs@sun-lamp.cs.berkeley.edu>
From: Havard Eidnes <Havard.Eidnes@runit.sintef.no>
List: netbsd-bugs
Date: 11/21/1993 16:49:46
------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"

Hi,

can I suggest the following amendments to the Makefile for hack?  This
modification does three things:

 1) "save game" will now work

 2) the Makefile is simplified by using "install -d"

 3) the owner of some of the installed files are changed to games.games
    instead of bin.bin, permission modified from 666 to 600.

Regards,

- Havard

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-Description: hack Makefile mods

*** Makefile.old	Mon Nov  8 11:17:34 1993
--- Makefile	Sun Nov 21 16:43:39 1993
***************
*** 31,45 ****
  
  beforeinstall: 
! 	@if [ ! -d ${DESTDIR}/var/games/hackdir ]; then \
!                 /bin/rm -f ${DESTDIR}/var/games/hackdir ; \
!                 mkdir -p ${DESTDIR}/var/games/hackdir ; \
!                 chown games.games ${DESTDIR}/var/games/hackdir ; \
!                 chmod 755 ${DESTDIR}/var/games/hackdir ; \
!         else \
!                 true ; \
!         fi
! 	install -c -o ${BINOWN} -g ${BINGRP} -m 666 /dev/null \
  	    ${DESTDIR}/var/games/hackdir/perm
! 	install -c -o ${BINOWN} -g ${BINGRP} -m 666 /dev/null \
  	    ${DESTDIR}/var/games/hackdir/record
  	install -c -o ${BINOWN} -g ${BINGRP} -m 444 ${.CURDIR}/help \
--- 31,39 ----
  
  beforeinstall: 
! 	install -d -m 755 -o games -g games ${DESTDIR}/var/games/hackdir
! 	install -d -m 700 -o games -g games ${DESTDIR}/var/games/hackdir/save
! 	install -c -o games -g games -m 600 /dev/null \
  	    ${DESTDIR}/var/games/hackdir/perm
! 	install -c -o games -g games -m 600 /dev/null \
  	    ${DESTDIR}/var/games/hackdir/record
  	install -c -o ${BINOWN} -g ${BINGRP} -m 444 ${.CURDIR}/help \

------- =_aaaaaaaaaa0--

------------------------------------------------------------------------------