Subject: Re: libkern compile on hp300
To: Allen Briggs <briggs@cray-ymp.acm.stuorg.vt.edu>
From: John Brezak <brezak@apollo.hp.com>
List: netbsd-bugs
Date: 03/11/1994 10:12:29
> > thought it'd be nice to be able to use one libkern for all m68k
> > machines, but with the addition of the disklabel stuff to libkern that
> > is no longer possible.
> >
> > Am I the only one who thinks this is dumb?
>
> Not particularly, although I don't see much advantage to sharing
> the libkern objects/library...
>
> Well, cpu_disklabel isn't used as far as I can tell. We're just
> getting it from including sys/disklabel.h. If a separation can
> be made between disklabel and cpu_disklabel, we wouldn't have this
> problem, yet. Should we have a machine/disklabel.h? Should
> sys/disklabel.h include it for backward compat., if so? If not,
> what's the gain, unless we do:
> #ifndef LIBKERN
> #include <machine/disklabel.h>
> #endif
> in sys/disklabel.h?
>
> -allen
I think that the ifdef's for machines in sys/disklabel.h should be cleaned up -
I agree with Allen. And Theo brings up a good point too. Maybe this file belongs
in a kern/vfs_disksubr.c (or a better name...) instead of libkern after all.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
John Brezak UUCP: uunet!apollo.hp!brezak
Hewlett Packard/Apollo Internet: brezak@ch.hp.com
300 Apollo Drive Phone: (508) 436-4915
Chelmsford, Massachusetts Fax: (508) 436-5122
------------------------------------------------------------------------------