Subject: Re: bin/674: makefile bug in src/usr.bin/tn3270/{tn3720,mset}
To: None <jonathan@dsg.stanford.edu>
From: Chris G Demetriou <Chris_G_Demetriou@LAGAVULIN.PDL.CS.CMU.EDU>
List: netbsd-bugs
Date: 01/02/1995 17:36:15
> >Description:
> 	Try doing a ``make'' in src/usr.bin/tn3270/tn3280, when
> 	``make obj'' has been done. (I.e,. the directory above has an
> 	obj/ subdirectory, or symlink to an /usr/obj/ tree.
> 	Make will complain that
> 
> "../../Makefile.inc", line 1: Need an operator
> Fatal errors encountered -- cannot continue
> 
> 	The same problem occurs in tn3270/mset.

it sounds to me like something was a bit overagressive in making obj
directories, here...

see the input/output i've pasted below.  you'll note that there is
_NOT_ (and should not be) an obj directory or link in
/usr/src/usr.bin/tn3270.  If you have one there, _something_ odd has
happened to your source tree (and i dare say it's not our fault...  8-).

> (Diagnosis:  Going by the mtime that sup left on the Makefiles, and
>  the RCS header, I'd hazard a guess that cgd goofed here...)

nope, i didn't touch that line; changed the man page specification,
and that was it.


This isn't really a bug.  however, in the spirit of good style and of
robustness, i've made the changes you suggest.  They don't hurt, they
_are_ the 'right' style, and they help in some (hosed) circumstances.


chris
==========================================================================
26 [sun-lamp] tn3270 % find . -name obj ; ls -la /usr/obj/usr.bin/tn3270
ls: /usr/obj/usr.bin/tn3270: No such file or directory
27 [sun-lamp] tn3270 % make obj
===> tools
===> mkhits
/usr/src/usr.bin/tn3270/tools/mkhits/obj -> /usr/obj/usr.bin/tn3270/tools/mkhits
===> mkastosc
/usr/src/usr.bin/tn3270/tools/mkastosc/obj -> /usr/obj/usr.bin/tn3270/tools/mkastosc
===> mkastods
/usr/src/usr.bin/tn3270/tools/mkastods/obj -> /usr/obj/usr.bin/tn3270/tools/mkastods
===> mkdstoas
/usr/src/usr.bin/tn3270/tools/mkdstoas/obj -> /usr/obj/usr.bin/tn3270/tools/mkdstoas
===> mkdctype
/usr/src/usr.bin/tn3270/tools/mkdctype/obj -> /usr/obj/usr.bin/tn3270/tools/mkdctype
===> tn3270
/usr/src/usr.bin/tn3270/tn3270/obj -> /usr/obj/usr.bin/tn3270/tn3270
===> mset
/usr/src/usr.bin/tn3270/mset/obj -> /usr/obj/usr.bin/tn3270/mset
You have new mail.
28 [sun-lamp] tn3270 % find . -name obj
./mset/obj
./tn3270/obj
./tools/mkastods/obj
./tools/mkastosc/obj
./tools/mkdctype/obj
./tools/mkdstoas/obj
./tools/mkhits/obj
29 [sun-lamp] tn3270 % make > /dev/null
/usr/src/usr.bin/tn3270/tn3270/../sys_curses/termout.c: In function `InitTerminal':
/usr/src/usr.bin/tn3270/tn3270/../sys_curses/termout.c:643: warning: type mismatch with previous external decl
<built-in>:0: warning: previous external decl of `abort'
/usr/src/usr.bin/tn3270/tn3270/../sys_curses/termout.c:643: warning: extern declaration of `abort' doesn't match global one
/usr/src/usr.bin/tn3270/tn3270/../sys_curses/termout.c:656: warning: passing arg 2 of `signal' from incompatible pointer type
/usr/src/usr.bin/tn3270/tn3270/../sys_curses/termout.c: In function `TransOut':
/usr/src/usr.bin/tn3270/tn3270/../sys_curses/termout.c:924: warning: passing arg 2 of `signal' from incompatible pointer type
/usr/src/usr.bin/tn3270/tn3270/../sys_curses/termout.c: At top level:
/usr/src/usr.bin/tn3270/tn3270/../sys_curses/termout.c:948: warning: `aborttc' was declared `extern' and later `static'
30 [sun-lamp] tn3270 %