>Number:         1219
>Category:       bin
>Synopsis:       [dM] fsck is too aggressive about clean flags
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 12 16:05:05 1995
>Originator:     der Mouse
>Organization:
	Dis-
>Release:        -current as of this morning, July 12th
>Environment:
	SPARC IPC, not that it matters
>Description:
	cgd's changes to fsck now make it so aggressive about believing
	clean flags that it will refuse to check a marked-clean
	filesystem even if you specifically give the disk device name.
	In my opinion this is excessive - giving a device name is a
	sufficiently clear indication that you want to check that
	filesystem regardless....
>How-To-Repeat:
	Run fsck with a disk device name, for a disk with a filesystem
	already marked as clean.
>Fix:
	Turn off skipclean if any explicit filesystem arguments are
	given.  (Yeah, chris, I know it's a unidiff, but I think in
	this case you won't find it hard to read :-)

--- /sources/supped/netbsd/src/./sbin/fsck/main.c	Wed Jul 12 02:58:27 1995
+++ /usr/src/./sbin/fsck/main.c	Wed Jul 12 15:54:39 1995
@@ -139,6 +139,7 @@
 	if (preen)
 		(void)signal(SIGQUIT, catchquit);
 	if (argc) {
+		skipclean = 0;
 		while (argc-- > 0)
 			(void)checkfilesys(blockcheck(*argv++), 0, 0L,
 			0);
 		exit(0);

					der Mouse

			    mouse@collatz.mcrcim.mcgill.edu
>Audit-Trail:
>Unformatted: