Subject: bin/1407: h[e[l[p]]] are not proper host names for telnet 'open'
To: None <gnats-bugs@gnats.netbsd.org>
From: Brian R. Gaeke <brg@dgate.org>
List: netbsd-bugs
Date: 08/26/1995 18:59:28
>Number:         1407
>Category:       bin
>Synopsis:       help, hel, he, h are not allowed as host names in telnet
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Aug 26 14:05:02 1995
>Last-Modified:
>Originator:     Brian R. Gaeke
>Organization:
The Dimensional Gate Co.
>Release:        NetBSD-current as of Sat Aug 26 03:51:28 1995
>Environment:
Apple Macintosh IIci (68030) NetBSD/mac68k 1.0A
System: NetBSD cheese.dgate.org 1.0A NetBSD 1.0A (IICIMINIM) #1: Thu Aug 24 05:01:31 EDT 1995 root@iici.dgate.org:/usr/src/sys/arch/mac68k/compile/IICIMINIM mac68k


>Description:
	telnet help, telnet hel, telnet he, telnet h, or (inside telnet)
        the commands: open help, open hel, open he, open h do not attempt
        to open a connection to specified host, rather they display a
        dubiously useful help message. IMO it is not as useful to display
        a help message in the case of the open command. Also ? can be used
        to produce the same effect, and ? is very much less likely to be
        a hostname than help.
>How-To-Repeat:
	example% telnet help
        usage: telnet [-l user] [-a] host-name [port]
        example% telnet
        telnet> open help
        usage: open [-l user] [-a] host-name [port]
>Fix:
	Change the applicable if (isprefix("help",*argv) || isprefix("?",*argv))
        clauses in commands.c to be simply if (isprefix("?",*argv)).
	One of these is at line 2102 of commands.c,v 1.8; I am not sure
        if there are others that would need to be changed as well.
>Audit-Trail:
>Unformatted: