>Number:         1425
>Category:       bin
>Synopsis:       send-pr.el doesn't work
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 31 03:20:04 1995
>Last-Modified:
>Originator:     Mike Long <mike.long@analog.com>
>Organization:
	As If, Inc.
>Release:        950830
>Environment:
System: NetBSD azathoth 1.0A NetBSD 1.0A (AZATHOTH) #1: Wed Aug 30 01:45:51 EDT 1995 root@azathoth:/usr/src/sys/arch/i386/compile/AZATHOTH i386

>Description:
1) send-pr.el doesn't work properly because

- there is no $GNATS_ROOT/gnats_adm/config file (as expected, because
I'm not running the GNATS PR repository).

- /bin/sh issues the error message ".:Can't open /gnats_adm/config"
instead of something starting with "/bin/sh", as send-pr.el expects.

2) I also found what I think is a typo in send-pr.el: one instance of
DEFAULT_CONFIDENTIAL should be DEFAULT_CLASS (or something similar)
instead.

3) There was also a problem in Makefile{,.in} which made the
Submitter-Id: show up as "xSUBMITTERx" instead of "net".

Applying this fix will make the lives of Emacs addicts like myself
much easier.

>How-To-Repeat:
	# (add send-pr autoloads to your .emacs)
	emacs -f send-pr
>Fix:
	Apply the following patches (Note that you have to reinstall
send-pr.el by hand):

*** /usr/src/gnu/usr.bin/send-pr/send-pr-el.in~ Mon Mar 20 02:17:37 1995
--- /usr/src/gnu/usr.bin/send-pr/send-pr-el.in  Thu Aug 31 02:07:58 1995
***************
*** 96,100 ****
        (shell-command (concat ". " gnats:root "/gnats-adm/config; echo $" var )
                     t)
!       (if (looking-at "/bin/sh:\\|\n")
          (setq ret nil)
        (setq ret (buffer-substring (point-min) (- (point-max) 1)))))
--- 96,100 ----
        (shell-command (concat ". " gnats:root "/gnats-adm/config; echo $" var )
                     t)
!       (if (looking-at ".:\\|\n")
          (setq ret nil)
        (setq ret (buffer-substring (point-min) (- (point-max) 1)))))
***************
*** 129,133 ****
         (, (or (gnats::get-config "DEFAULT_CATEGORY") nil)) enum)
        ("Class" (("sw-bug") ("doc-bug") ("change-request") ("support"))
!        (, (or (gnats::get-config "DEFAULT_CONFIDENTIAL") 0)) enum)
        ("Confidential" (("yes") ("no"))
         (, (or (gnats::get-config "DEFAULT_CONFIDENTIAL") 1)) enum)
--- 129,133 ----
         (, (or (gnats::get-config "DEFAULT_CATEGORY") nil)) enum)
        ("Class" (("sw-bug") ("doc-bug") ("change-request") ("support"))
!        (, (or (gnats::get-config "DEFAULT_CLASS") 0)) enum)
        ("Confidential" (("yes") ("no"))
         (, (or (gnats::get-config "DEFAULT_CONFIDENTIAL") 1)) enum)

*** /usr/src/gnu/usr.bin/send-pr/Makefile.in~   Mon Mar 20 02:17:33 1995
--- /usr/src/gnu/usr.bin/send-pr/Makefile.in    Thu Aug 31 01:45:46 1995
***************
*** 140,144 ****
            -e 's,xGNATS_SITEx,$(GNATS_SITE),' \
            -e 's,xDATADIRx,$(datadir),' \
!           -e 's,xDEFAULT_SUBMITTERx,$(SUBMITTER),' \
            -e 's,xDEFAULT_RELEASEx,$(DEFAULT_RELEASE),' \
                $(srcdir)/send-pr-el.in \
--- 140,144 ----
            -e 's,xGNATS_SITEx,$(GNATS_SITE),' \
            -e 's,xDATADIRx,$(datadir),' \
!           -e 's,xSUBMITTERx,$(SUBMITTER),' \
            -e 's,xDEFAULT_RELEASEx,$(DEFAULT_RELEASE),' \
                $(srcdir)/send-pr-el.in \

*** /usr/src/gnu/usr.bin/send-pr/Makefile~      Tue Jun 20 06:30:44 1995
--- /usr/src/gnu/usr.bin/send-pr/Makefile       Thu Aug 31 01:18:47 1995
***************
*** 80,84 ****
              -e 's,xGNATS_SITEx,$(GNATS_SITE),' \
              -e 's,xDATADIRx,$(datadir),' \
!             -e 's,xDEFAULT_SUBMITTERx,$(SUBMITTER),' \
              -e 's,xDEFAULT_RELEASEx,$(DEFAULT_RELEASE),' \
                $(srcdir)/send-pr-el.in \
--- 80,84 ----
              -e 's,xGNATS_SITEx,$(GNATS_SITE),' \
              -e 's,xDATADIRx,$(datadir),' \
!             -e 's,xSUBMITTERx,$(SUBMITTER),' \
              -e 's,xDEFAULT_RELEASEx,$(DEFAULT_RELEASE),' \
                $(srcdir)/send-pr-el.in \

>Audit-Trail:
>Unformatted: