Subject: port-amiga/1656: without grful in conf, kernel make depend should not need gspa*
To: None <gnats-bugs@gnats.netbsd.org>
From: Ignatios Souvatzis <is@beverly.rhein.de>
List: netbsd-bugs
Date: 10/20/1995 13:27:36
>Number: 1656
>Category: port-amiga
>Synopsis: kernel make depend shouldn't need gspa if not necessary
>Confidential: no
>Severity: non-critical
>Priority: high
>Responsible: gnats-admin (GNATS administrator)
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Oct 20 08:50:00 1995
>Last-Modified:
>Originator: Ignatios Souvatzis
>Organization:
make analyzers 'r' us
>Release: 951016
>Environment:
System: NetBSD beverly 1.1_ALPHA NetBSD 1.1_ALPHA (BEVERLY) #245: Fri Oct 20 12:37:01 MET 1995 is@beverly:/usr/src/sys/arch/amiga/compile/BEVERLY amiga
>Description:
At the moment, the kernel depending needs grf_ultmscode.h to be built,
which in turn needs an installed gspa & gspahextoc.
This should not be necessary if grful/grf4/ite4 are not configured.
>How-To-Repeat:
configure a kernel without grful/grf4/ite4; make depend; watch
>Fix:
I finally found out why make didn't initialize the $< macro correctly
for the NORMAL_G rule: a default rule for the same suffix has to be
present. After introducing a dummy default rule we don't need the
current hack any longer.
The appended diff
- tells usr.sbin/gspa/gspahextoc to add an
#include <sys/types.h> for u_int16_t
- adds grf_ultms.g to the files.amiga for the grful device
- changes Makefile.amiga to
* throw out the earlier hack
* create a dummy .g.o rule (else $< does not work)
* add a NORMAL_G rule
- changes arch/amiga/dev/grf_ul.c to not include grf_ultmscode.h, but
reference the extern u_int16_t tmscode[] instead.
In addition, sys/arch/amiga/dev/grf_ul.gsp has to be renamed to
sys/arch/amiga/dev/grf_ultms.g
>Audit-Trail:
>Unformatted:
Ignatios Souvatzis