>Number:         2326
>Category:       port-sparc
>Synopsis:       options BLINK will not compile without changes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 14 05:05:00 1996
>Last-Modified:
>Originator:     Peter Galbavy
>Organization:
Peter Galbavy                                           peter@wonderland.org
@ Home                                                 phone://44/973/499465
in Wonderland                              http://www.wonderland.org/~peter/
                               snail://UK/NW1_6LE/London/21_Harewood_Avenue/
>Release:        NetBSD-1.1B (current to April 11th 1996)
>Environment:
NetBSD/sparc SS10
System: NetBSD alice.wonderland.org 1.1B NetBSD 1.1B (ALICE) #0: Mon Apr 8 12:14:30 BST 1996 peter@alice.wonderland.org:/humpty/work/netbsd/src/sys/arch/sparc/compile/ALICE sparc


>Description:
	with -Werror and options BLINK, the funtion needs defining
	and changing to return void, so that the args to timeout()
	will be OK.

	Oh, and an unused var "lav" too.

>How-To-Repeat:
	add options BLINK to your config file and watch the kernel not
	compile.

>Fix:
*** ../../../../arch/sparc/sparc/auxreg.c.orig	Sun Apr 14 09:50:09 1996
--- ../../../../arch/sparc/sparc/auxreg.c	Sun Apr 14 10:01:12 1996
***************
*** 54,59 ****
--- 54,62 ----
  #include <sparc/sparc/vaddrs.h>
  #include <sparc/sparc/auxreg.h>
  
+ #ifdef BLINK
+ static void blink __P((void *));
+ #endif
  static int auxregmatch __P((struct device *, void *, void *));
  static void auxregattach __P((struct device *, struct device *, void *));
  
***************
*** 66,77 ****
  };
  
  #ifdef BLINK
! static int
  blink(zero)
  	void *zero;
  {
  	register int s;
- 	register fixpt_t lav;
  
  	s = splhigh();
  	LED_FLIP;
--- 69,79 ----
  };
  
  #ifdef BLINK
! static void
  blink(zero)
  	void *zero;
  {
  	register int s;
  
  	s = splhigh();
  	LED_FLIP;
>Audit-Trail:
>Unformatted: