Subject: bin/2357: named makefiles fail with NOMAN defined
To: None <gnats-bugs@NetBSD.ORG>
From: Luke Mewburn <lukem@supp.cpr.itg.telecom.com.au>
List: netbsd-bugs
Date: 04/30/1996 14:21:19
>Number: 2357
>Category: bin
>Synopsis: named makefiles fail with NOMAN defined
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: bin-bug-people (Utility Bug People)
>State: open
>Class: sw-bug
>Submitter-Id: lm
>Arrival-Date: Tue Apr 30 00:50:03 1996
>Last-Modified:
>Originator: Luke Mewburn
>Organization:
Werj
>Release: NetBSD-960430
>Environment:
NetBSD shelob 1.1B NetBSD 1.1B (SHELOB) #0: Wed Apr 17 10:14:36 EST 1996 root@shelob:/z/src/sys/arch/i386/compile/SHELOB i386
>Description:
The makefiles for named/{ndc,named.reload,named.restart} are
coded such that they won't work if "NOMAN" is defined.
>How-To-Repeat:
setenv NOMAN
cd /usr/src/usr.sbin/named/ndc
make
>Fix:
apply this patch. it's a working solution to get around the
fact that no actual 'PROG' is built for these directories.
it also reorders the including of "../../Makefile.inc"
this works with or without NOMAN set.
diff -rc /ftp/pub/NetBSD/NetBSD-current/src/usr.sbin/named/ndc/Makefile ./ndc/Makefile
*** /ftp/pub/NetBSD/NetBSD-current/src/usr.sbin/named/ndc/Makefile Sat Feb 3 23:34:00 1996
--- ./ndc/Makefile Tue Apr 30 14:00:12 1996
***************
*** 4,15 ****
.PATH: ${.CURDIR}/../named \
${.CURDIR}/../man
- all: ndc ndc.cat8
-
CLEANFILES+= ndc
MAN= ndc.8
! realinstall:
install -c -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
ndc ${DESTDIR}${BINDIR}/ndc
--- 4,13 ----
.PATH: ${.CURDIR}/../named \
${.CURDIR}/../man
CLEANFILES+= ndc
MAN= ndc.8
! realinstall: ndc
install -c -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
ndc ${DESTDIR}${BINDIR}/ndc
***************
*** 21,25 ****
< ${.CURDIR}/ndc.sh > ndc
chmod +x ndc
- .include <bsd.prog.mk>
.include "../../Makefile.inc"
--- 19,23 ----
< ${.CURDIR}/ndc.sh > ndc
chmod +x ndc
.include "../../Makefile.inc"
+ .include <bsd.prog.mk>
diff -rc /ftp/pub/NetBSD/NetBSD-current/src/usr.sbin/named/reload/Makefile ./reload/Makefile
*** /ftp/pub/NetBSD/NetBSD-current/src/usr.sbin/named/reload/Makefile Sat Feb 3 23:34:00 1996
--- ./reload/Makefile Tue Apr 30 14:04:21 1996
***************
*** 4,15 ****
.PATH: ${.CURDIR}/../named \
${.CURDIR}/../man
- all: named.reload named.reload.cat8
-
CLEANFILES+= named.reload
MAN= named.reload.8
! realinstall:
install -c -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
named.reload ${DESTDIR}${BINDIR}/named.reload
--- 4,13 ----
.PATH: ${.CURDIR}/../named \
${.CURDIR}/../man
CLEANFILES+= named.reload
MAN= named.reload.8
! realinstall: named.reload
install -c -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
named.reload ${DESTDIR}${BINDIR}/named.reload
***************
*** 18,22 ****
< ${.CURDIR}/named.reload.sh > named.reload
chmod +x named.reload
- .include <bsd.prog.mk>
.include "../../Makefile.inc"
--- 16,20 ----
< ${.CURDIR}/named.reload.sh > named.reload
chmod +x named.reload
.include "../../Makefile.inc"
+ .include <bsd.prog.mk>
diff -rc /ftp/pub/NetBSD/NetBSD-current/src/usr.sbin/named/restart/Makefile ./restart/Makefile
*** /ftp/pub/NetBSD/NetBSD-current/src/usr.sbin/named/restart/Makefile Sat Feb 3 23:34:00 1996
--- ./restart/Makefile Tue Apr 30 14:04:45 1996
***************
*** 4,15 ****
.PATH: ${.CURDIR}/../named \
${.CURDIR}/../man
- all: named.restart named.restart.cat8
-
CLEANFILES+= named.restart
MAN= named.restart.8
! realinstall:
install -c -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
named.restart ${DESTDIR}${BINDIR}/named.restart
--- 4,13 ----
.PATH: ${.CURDIR}/../named \
${.CURDIR}/../man
CLEANFILES+= named.restart
MAN= named.restart.8
! realinstall: named.restart
install -c -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
named.restart ${DESTDIR}${BINDIR}/named.restart
***************
*** 18,22 ****
< ${.CURDIR}/named.restart.sh > named.restart
chmod +x named.restart
- .include <bsd.prog.mk>
.include "../../Makefile.inc"
--- 16,20 ----
< ${.CURDIR}/named.restart.sh > named.restart
chmod +x named.restart
.include "../../Makefile.inc"
+ .include <bsd.prog.mk>
>Audit-Trail:
>Unformatted: