Subject: misc/2450: chat does not allow comments in its scripts
To: None <gnats-bugs@NetBSD.ORG>
From: None <ksulliva@psc.edu>
List: netbsd-bugs
Date: 05/21/1996 12:24:28
>Number: 2450
>Category: misc
>Synopsis: chat does not allow comments in its scripts
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: misc-bug-people (Misc Bug People)
>State: open
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Tue May 21 12:35:04 1996
>Last-Modified:
>Originator: Kevin Sullivan
>Organization:
Pittsburgh Supercomputing Center
>Release: 1.1
>Environment:
System: NetBSD kludge.psc.edu 1.1 NetBSD 1.1 (KLUDGE) #0: Fri Feb 9 12:15:08 EST 1996 ksulliva@sparta.schenley.pps.pgh.pa.us:/home/system/src/sys/arch/i386/compile/KLUDGE i386
>Description:
pppd allows hash-comments in its scripts, but chat doesn't. Comments are always a good idea!
>How-To-Repeat:
>Fix:
This fix will only allow comments where the hash is in the first
column. A more general solution is possible put probably not needed
for chat.
*** /usr/src/usr.sbin/pppd/chat/chat.c Sat Oct 14 00:05:55 1995
--- chat.c Tue May 21 12:11:47 1996
***************
*** 334,337 ****
--- 334,340 ----
linect++;
sp = buf;
+ if (*sp == '#') {
+ continue;
+ }
while (*sp != '\0')
{
>Audit-Trail:
>Unformatted: