Subject: bin/2651: `make' prints extra leading make: and trailing newline if there is no target
To: None <gnats-bugs@NetBSD.ORG>
From: None <enami@ba2.so-net.or.jp>
List: netbsd-bugs
Date: 07/23/1996 23:21:36
>Number:         2651
>Category:       bin
>Synopsis:       `make' prints extra leading make: and trailing newline if there is no target
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 23 11:05:15 1996
>Last-Modified:
>Originator:     enami tsugutomo
>Organization:
	a hacker in japan
>Release:        1.2_BETA
>Environment:
System: NetBSD pavlov.enami.ba2.so-net.or.jp 1.2_BETA NetBSD 1.2_BETA (PAVLOV) #67: Sat Jul 13 12:35:02 JST 1996 enami@pavlov.enami.ba2.so-net.or.jp:/usr/src/sys/arch/i386/compile/PAVLOV i386


>Description:
	`make' command prints extra leading `make: ' and extra trailing
	newline if there is no target to make.
>How-To-Repeat:
	Creat empty directory and change directory to there.  Then, just
	invoke make.  The log will be like this:

enami@pavlov% make
make: make: no target to make.

enami@pavlov% exit

	Note that leading `make: ' is duplicated and there is extra empty
	line.

>Fix:
	Because the function Punt() in main.c takes care of leading
	make: and trailing newline, so, there is no need to pass explicitly.
	Here is supporsed fix.

Index: parse.c
===================================================================
RCS file: /a/cvsroot/NetBSD/usr.bin/make/parse.c,v
retrieving revision 1.1.1.4
diff -u -r1.1.1.4 parse.c
--- parse.c	1996/04/30 07:33:51	1.1.1.4
+++ parse.c	1996/07/23 14:12:26
@@ -2689,7 +2689,7 @@
     main = Lst_Init (FALSE);
 
     if (mainNode == NILGNODE) {
-	Punt ("make: no target to make.\n");
+	Punt ("no target to make.");
     	/*NOTREACHED*/
     } else if (mainNode->type & OP_DOUBLEDEP) {
 	(void) Lst_AtEnd (main, (ClientData)mainNode);
>Audit-Trail:
>Unformatted: