>Number:         3566
>Category:       kern
>Synopsis:       typo in /src/sys/dev/audio.c: rparams -> sc_rparams
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people (Kernel Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu May  1 05:05:02 1997
>Last-Modified:
>Originator:     Thorsten Frueauf
>Organization:
private
	
>Release:        <NetBSD-current source date> NetBSD current 30.4.1997
>Environment:
	
System: NetBSD cyberlap 1.2D NetBSD 1.2D (CYBERLAP) #3: Wed Apr 30 13:27:45 CEST 1997 frueauf@cyberlap:/usr/src/sys/arch/i386/compile/CYBERLAP i386


>Description:
	
/src/sys/dev/audio.c contains a type rparams -> sc_rparams which is only
visible with option DIAGNOSTIC turned on.

>How-To-Repeat:
	
Compile a recent kernel with "options DIAGNOSTIC" turned on, and watch:

cc -g -O2 -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes -I. -I../../../../arch -I../../../.. -nostdinc -DSWAPPAGER -DVNODEPAGER -DDEVPAGER -DEXEC_AOUT -DEXEC_SCRIPT -DI586_CPU -DMATH_EMULATE -DDUMMY_NOPS -DXSERVER -DUCONSOLE -DINSECURE -DRTC_OFFSET="0" -DDIAGNOSTIC -DKTRACE -DSYSVMSG -DSYSVSEM -DSYSVSHM -DCOMPAT_NOMID -DCOMPAT_09 -DCOMPAT_10 -DCOMPAT_11 -DCOMPAT_12 -DCOMPAT_43 -DTCP_COMPAT_42 -DCOMPAT_LINUX -DCOMPAT_FREEBSD -DEXEC_ELF32 -DUSER_LDT -DLKM -DFFS -DMFS -DNFS -DCD9660 -DMSDOSFS -DFDESC -DKERNFS -DNULLFS -DPROCFS -DUMAPFS -DUNION -DNFSSERVER -DFIFO -DINET -DPFIL_HOOKS -DPCVT_CTRL_ALT_DEL -DPCVT_NSCREENS="8" -DCOLOR_KERNEL_BG="BG_BLACK" -DMAXUSERS=32 -D_KERNEL  -Di386  -c ../../../../dev/audio.c
../../../../dev/audio.c: In function `audio_open':
../../../../dev/audio.c:555: structure has no member named `rparams'
*** Error code 1

>Fix:
	
Apply the following patch to /src/sys/dev/audio.c:


*** audio.c-orig	Thu May  1 03:07:18 1997
--- audio.c	Thu May  1 13:29:07 1997
***************
*** 552,558 ****
  	 * us these values.
  	 */
  #ifdef DIAGNOSTIC
! 	if (sc->rparams.precision == 0 || sc->sc_pparams.precision == 0) {
  		printf("audio_open: 0 precision\n");
  		return EINVAL;
  	}
--- 552,558 ----
  	 * us these values.
  	 */
  #ifdef DIAGNOSTIC
! 	if (sc->sc_rparams.precision == 0 || sc->sc_pparams.precision == 0) {
  		printf("audio_open: 0 precision\n");
  		return EINVAL;
  	}
>Audit-Trail:
>Unformatted:
typo in /src/sys/dev/audio.c: rparams -> sc_rparams