>Number:         3864
>Category:       port-i386
>Synopsis:       some things missed at satlink integration
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 14 13:35:01 1997
>Last-Modified:
>Originator:     Thorsten Frueauf
>Organization:
private
	
>Release:        <NetBSD-current source date> NetBSD current 14.7.1997
>Environment:
	
System: NetBSD cyberlap 1.2G NetBSD 1.2G (CYBERLAP) #4: Fri Jul 11 22:24:55 CEST 1997 frueauf@cyberlap:/usr/src/sys/arch/i386/compile/CYBERLAP i386


>Description:
	
With the satlink integration, satlink _always_ gets used - whether it is
commended out in the kernel file or not - it misses the "needs-flag" and
its proper handling.

>How-To-Repeat:
	
Try to compile a current kernel on port-i386 with satlink commendet out
in the kernel config file, and watch ld complaining about missing
satlink symbols.

>Fix:
	
Apply the following patch to /src/sys/dev/isa/files.isa and
/src/sys/arch/i386/i386/conf.c:

*** files.isa-orig	Mon Jul 14 16:55:42 1997
--- files.isa	Mon Jul 14 22:07:05 1997
***************
*** 248,254 ****
  #
  device satlink: isadma
  attach satlink at isa
! file dev/isa/satlink.c	satlink
  
  #
  # PCMCIA PCIC (i82365SL and compatibles):
--- 248,254 ----
  #
  device satlink: isadma
  attach satlink at isa
! file dev/isa/satlink.c	satlink needs-flag
  
  #
  # PCMCIA PCIC (i82365SL and compatibles):
*** conf.c-orig	Mon Jul 14 17:54:22 1997
--- conf.c	Mon Jul 14 22:17:28 1997
***************
*** 190,195 ****
--- 190,196 ----
  #include "apm.h"
  cdev_decl(apm);
  #include "ipfilter.h"
+ #include "satlink.h"
  cdev_decl(satlink);
  #include "pcmciabus.h"
  cdev_decl(pcmciabus);
***************
*** 245,251 ****
  	cdev_notdef(),			/* 43 */
  #endif
  	cdev_ipf_init(NIPFILTER,ipl),	/* 44: ip-filter device */
! 	cdev_satlink_init(1,satlink),	/* 45: planetconnect satlink */
  	cdev_disk_init(NACD,acd),	/* 46: ATAPI CD-ROM */
  };
  int	nchrdev = sizeof(cdevsw) / sizeof(cdevsw[0]);
--- 246,252 ----
  	cdev_notdef(),			/* 43 */
  #endif
  	cdev_ipf_init(NIPFILTER,ipl),	/* 44: ip-filter device */
! 	cdev_satlink_init(NSATLINK,satlink),	/* 45: planetconnect satlink */
  	cdev_disk_init(NACD,acd),	/* 46: ATAPI CD-ROM */
  };
  int	nchrdev = sizeof(cdevsw) / sizeof(cdevsw[0]);
>Audit-Trail:
>Unformatted:
some things missed at satlink integration