Subject: kern/4091: minor ANSI violations in headers
To: None <gnats-bugs@gnats.netbsd.org>
From: None <David.Sainty@MCS.VUW.AC.NZ>
List: netbsd-bugs
Date: 09/07/1997 00:03:42
>Number: 4091
>Category: kern
>Synopsis: minor ANSI violations in headers
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people (Kernel Bug People)
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Sep 6 05:05:01 1997
>Last-Modified:
>Originator: Dave Sainty
>Organization:
>Release: pretty recent current
>Environment:
>Description:
/usr/include/net/if_arp.h has uncommented text after a #endif. A
quick grep reveals /usr/include/netiso/argo_debug.h does too btw.
>How-To-Repeat:
grep -v '^#endif[ \t]*$' /usr/include/**/*.h |fgrep '#endif'|fgrep -v '/*'
Notice from the handful of lines that there are a few violations,
namely:
net/if_arp.h:#endif _IF_ARP_H_
netiso/argo_debug.h: #endif TPPT
netiso/argo_debug.h: #endif TP_PERF_MEAS
>Fix:
Patch for if_arp.h
--- /usr/include/net/if_arp.h Wed Mar 26 00:22:14 1997
+++ if_arp.h Sat Sep 6 23:47:48 1997
@@ -96,4 +96,4 @@
#define ATF_PUBL 0x08 /* publish entry (respond for other host) */
#define ATF_USETRAILERS 0x10 /* has requested trailers */
-#endif _IF_ARP_H_
+#endif /* _IF_ARP_H_ */
>Audit-Trail:
>Unformatted:
System: NetBSD tequila.ext.nz 1.2G NetBSD 1.2G (TEQUILA) #34: Sat Aug 23 02:42:39 NZST 1997 dave@tequila.ext.nz:/vol/tequila/userC/NetBSD-current/src/sys/arch/i386/compile/TEQUILA i386