Subject: port-mac68k/4633: mc driver won't compile without DDB
To: None <gnats-bugs@gnats.netbsd.org>
From: Dave Huang <khym@bga.com>
List: netbsd-bugs
Date: 12/03/1997 02:48:03
>Number: 4633
>Category: port-mac68k
>Synopsis: mc driver won't compile without DDB
>Confidential: no
>Severity: non-critical
>Priority: high
>Responsible: gnats-admin (GNATS administrator)
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Dec 3 22:20:11 1997
>Last-Modified:
>Originator: Dave Huang
>Organization:
Name: Dave Huang | Mammal, mammal / their names are called /
INet: khym@bga.com | they raise a paw / the bat, the cat /
FurryMUCK: Dahan | dolphin and dog / koala bear and hog -- TMBG
Dahan: Hani G Y+C 22 Y++ L+++ W- C++ T++ A+ E+ S++ V++ F- Q+++ P+ B+ PA+ PL++
>Release: NetBSD 1.3_BETA as of December 3, 1997
>Environment:
System: NetBSD dahan.metonymy.com 1.3_BETA NetBSD 1.3_BETA (SPIFF) #167: Mon Dec 1 01:33:18 CST 1997 khym@dahan.metonymy.com:/usr/src.local/sys/arch/i386/compile/SPIFF i386
>Description:
The mc driver (if_mc*) won't compile if DDB isn't defined.
>How-To-Repeat:
Try to compile a kernel without "options DDB"
>Fix:
Not sure what'd be good... this seems kinda yucky, but it
works... what'd be nicer is __inline if no DDB, nothing if DDB:
--- /usr/src/sys/arch/mac68k/dev/if_mc.c Wed Nov 12 14:55:32 1997
+++ if_mc.c Wed Dec 3 02:35:38 1997
@@ -524,7 +524,7 @@
mc_rint(sc);
}
-integrate void
+__inline void
mc_tint(sc)
struct mc_softc *sc;
{
@@ -569,7 +569,7 @@
mcstart(&sc->sc_if);
}
-integrate void
+__inline void
mc_rint(sc)
struct mc_softc *sc;
{
--- /usr/src/sys/arch/mac68k/dev/if_mcvar.h Wed Nov 12 14:55:33 1997
+++ if_mcvar.h Wed Dec 3 02:35:28 1997
@@ -87,7 +87,7 @@
int mcsetup __P((struct mc_softc *, u_int8_t *));
void mcintr __P((void *arg));
-integrate void mc_tint __P((struct mc_softc *sc));
-integrate void mc_rint __P((struct mc_softc *sc));
+__inline void mc_tint __P((struct mc_softc *sc));
+__inline void mc_rint __P((struct mc_softc *sc));
u_char mc_get_enaddr __P((bus_space_tag_t t, bus_space_handle_t h,
vm_offset_t o, u_char *dst));
>Audit-Trail:
>Unformatted: