Subject: pkg/4884: /usr/share/mk/{bsd.README,bsd.port.*.mk} use STRIP instead of STRIPFLAG
To: None <gnats-bugs@gnats.netbsd.org>
From: None <jbernard@tater.mines.edu>
List: netbsd-bugs
Date: 01/24/1998 15:38:55
>Number:         4884
>Category:       pkg
>Synopsis:       /usr/share/mk/{bsd.README,bsd.port.*.mk} use STRIP instead of STRIPFLAG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 24 14:50:01 1998
>Last-Modified:
>Originator:     Jim Bernard
>Organization:
	Speaking for myself
>Release:        Jan 24, 1998
>Environment:
System: NetBSD zoo 1.3_BETA NetBSD 1.3_BETA (ZOO) #0: Sat Dec 6 09:47:11 MST 1997 local@zoo:/home/local/compile/sys/arch/i386/compile/ZOO i386


>Description:
	The symbol STRIP is documented in bsd.README as the flag passed to
	install to cause the binary to be stripped.  It is used in that
	manner in bsd.port.mk and bsd.port.subdir.mk.  However, the rest
	of the make system uses the name STRIPFLAG instead, so packages are
	not installed with the binaries stripped.

>How-To-Repeat:
	Install a package and wonder why the binaries aren't stripped.
	Add a target to the top-level Makefile that just does
	"echo ${INSTALL_PROGRAM}" and note that the strip flag is missing.
	Change STRIP to STRIPFLAG in the definition of INSTALL_PROGRAM in
	bsd.port.mk and voila, the -s appears.

>Fix:
	The fix to bsd.README is trivial.

	I checked the /usr/share/mk tree for FreeBSD, and it uses STRIP
	throughout, so it would appear that NetBSD was changed at some
	point without updating bsd.README, and the import of the FreeBSD
	ports system (package system here) did not include adapting to
	the change to STRIPFLAG.

	So, it will require a bit of care to modify bsd.port.mk and
	bsd.port.subdir.mk to maintain compatibility with FreeBSD
	(I didn't check OpenBSD, but that may add another constraint).
	I'll leave it up to the package-system folks to decide the
	best way to accomplish that.
>Audit-Trail:
>Unformatted: