Subject: Re: port-alpha/4903: using DEC's isp10X0 F/W fails to fireup correctly after boot
To: None <cgd@pa.dec.com>
From: Matthew Jacob <mjacob@feral.com>
List: netbsd-bugs
Date: 01/28/1998 00:49:21
Actually, I *am* leaving the flag alone, but I'm also making the
following change too:
Index: isp.c
===================================================================
RCS file: /cvsroot/src/sys/dev/ic/isp.c,v
retrieving revision 1.17
diff -u -r1.17 isp.c
--- isp.c 1998/01/12 09:23:26 1.17
+++ isp.c 1998/01/28 08:49:31
@@ -265,11 +265,15 @@
}
/*
- * Download new Firmware, unless requested not to
- * or not appropriate to do so.
+ * Download new Firmware, unless requested not to do so.
+ * This is made slightly trickier in some cases where the
+ * firmware of the ROM revision is newer than the revision
+ * compiled into the driver. So, where we used to compare
+ * versions of our f/w and the ROM f/w, now we just see
+ * whether we have f/w at all and whether a config flag
+ * has disabled our download.
*/
- if ((isp->isp_fwrev >= isp->isp_mdvec->dv_fwrev) ||
- (cf_flags & 0x80) != 0) {
+ if (isp->isp_mdvec->dv_fwlen == 0 || (cf_flags & 0x80) != 0) {
dodnld = 0;
}