Subject: port-amiga/5232: amiga/dev/ser.c still uses TS_WOPEN which got removed from sys/tty.h
To: None <gnats-bugs@gnats.netbsd.org>
From: None <frueauf@ira.uka.de>
List: netbsd-bugs
Date: 03/30/1998 18:43:20
>Number:         5232
>Category:       port-amiga
>Synopsis:       amiga/dev/ser.c still uses TS_WOPEN which got removed from sys/tty.h
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 30 08:50:00 1998
>Last-Modified:
>Originator:     Thorsten Frueauf
>Organization:
private
>Release:        <NetBSD-current source date> NetBSD current 29.3.1998
>Environment:
	
System: NetBSD di-frueauf 1.3E NetBSD 1.3E (CYBERDYNE) #6: Fri Mar 13 16:43:41 MET 1998 milano@di-frueauf:/src/sys/arch/amiga/compile/CYBERDYNE amiga


>Description:
	
Arround the 21.03.1998 mycroft removed TS_WOPEN from sys/tty.h and introduced
t_wopen to the tty struct. But somehow amiga/dev/ser.c got forgotten to
reflect that.

>How-To-Repeat:
	
Try to make a current kernel on amiga with ser.c enabled, and watch:

cc  -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -O2 -m68060 -Wa,-m68030 -msoft-float -I. -I../../../../arch -I../../../.. -nostdinc -DMACHINE_NEW_NONCONTIG -DBB060STUPIDROM -DM68060 -DM060SP -DM68030 -DINET -DGATEWAY -DPFIL_HOOKS -DIPFILTER_LOG -DNFSSERVER -DFIFO -DCOMPAT_43 -DCOMPAT_09 -DCOMPAT_10 -DCOMPAT_12 -DCOMPAT_13 -DCOMPAT_SUNOS -DCOMPAT_NOMID -DSYSVSHM -DSYSVMSG -DSYSVSEM -DKTRACE -DLKM -DNKMEMCLUSTERS="0x400" -DNMBCLUSTERS="0x400" -DCL5426CONSOLE -DMAXUSERS=32 -D_KERNEL  -Dmc68020 -Damiga -DFPCOPROC  -c ../../../../arch/amiga/dev/ser.c
../../../../arch/amiga/dev/ser.c: In function `seropen':
../../../../arch/amiga/dev/ser.c:265: `TS_WOPEN' undeclared (first use this function)
../../../../arch/amiga/dev/ser.c:265: (Each undeclared identifier is reported only once
../../../../arch/amiga/dev/ser.c:265: for each function it appears in.)
../../../../arch/amiga/dev/ser.c: In function `sermint':
../../../../arch/amiga/dev/ser.c:580: `TS_WOPEN' undeclared (first use this function)
*** Error code 1

>Fix:
	
Rewrite amiga/dev/ser.c to reflect that change.
>Audit-Trail:
>Unformatted:
amiga/dev/ser.c still uses TS_WOPEN which got removed from sys/tty.h