Subject: pkg/5317: bsd.pkg.mk sets wrong *DEPENDS if USE_GTEXINFO and PREFIX = X11BASE
To: None <gnats-bugs@gnats.netbsd.org>
From: None <jbernard@tater.mines.edu>
List: netbsd-bugs
Date: 04/18/1998 20:21:16
>Number: 5317
>Category: pkg
>Synopsis: bsd.pkg.mk sets wrong *DEPENDS if USE_GTEXINFO and PREFIX = X11BASE
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: gnats-admin (GNATS administrator)
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Apr 18 19:35:00 1998
>Last-Modified:
>Originator: Jim Bernard
>Organization:
Speaking for myself
>Release: April 18, 1998
>Environment:
System: NetBSD zoo 1.3E NetBSD 1.3E (ZOO) #0: Thu Mar 19 17:34:34 MST 1998 local@zoo:/home/local/compile/sys/arch/i386/compile/ZOO i386
>Description:
When USE_GTEXINFO is "yes" bsd.pkg.mk sets BUILD_DEPENDS and
RUN_DEPENDS to ${PREFIX}/bin/install-info:..., but this is incorrect
if PREFIX for the package being built is X11BASE, since the gtexinfo
package puts install-info in LOCALBASE/bin.
>How-To-Repeat:
Try to build/install the gtk package (e.g.).
>Fix:
One could simply use LOCALBASE instead of PREFIX. However, this
could fail if LOCALBASE has changed since gtexinfo was installed,
so it's better to use the same approach used for USE_GMAKE and
USE_PERL5, which is to use the basename (install-info) sans dirname,
or a variable that defaults to that but can be overridden. The latter
approaches also have the advantage of being able to make use of texinfo
installations that are independent of the package system. The patch
below uses the basename directly, rather than defining an overridable
variable, as is done with ${GMAKE}.
--- bsd.pkg.mk-dist Fri Apr 17 05:23:31 1998
+++ bsd.pkg.mk Sat Apr 18 19:01:51 1998
@@ -437,12 +437,12 @@
.endif
.if defined(INFO_FILES)
USE_GTEXINFO= yes
.endif
.if defined(USE_GTEXINFO)
-BUILD_DEPENDS+= ${PREFIX}/bin/install-info:${PORTSDIR}/devel/gtexinfo
-RUN_DEPENDS+= ${PREFIX}/bin/install-info:${PORTSDIR}/devel/gtexinfo
+BUILD_DEPENDS+= install-info:${PORTSDIR}/devel/gtexinfo
+RUN_DEPENDS+= install-info:${PORTSDIR}/devel/gtexinfo
.endif
.if exists(${PORTSDIR}/../Makefile.inc)
.include "${PORTSDIR}/../Makefile.inc"
>Audit-Trail:
>Unformatted: