Subject: pkg/5609: kermit pkg not 64bit clean, compiles with -Werror
To: None <gnats-bugs@gnats.netbsd.org>
From: Tim Rightnour <root@polaris.garbled.net>
List: netbsd-bugs
Date: 06/18/1998 05:50:38
>Number:         5609
>Category:       pkg
>Synopsis:       kermit pkg not 64bit clean, compiles with -Werror
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jun 18 05:50:01 1998
>Last-Modified:
>Originator:     Tim Rightnour
>Organization:
Tim Rightnour    -  root@garbled.net
http://www.zynetwc.com/~garbled/garbled.html
>Release:        6/10/98<NetBSD-current source date>
>Environment:
	
System: NetBSD polaris 1.3 NetBSD 1.3 (POLARIS) #0: Thu Mar 26 13:17:18 MST 1998 root@polaris:/usr/src/sys/arch/i386/compile/POLARIS i386


>Description:
Kermit is not 64 bit clean.. The makefile requests that it be compiled with -Werror, and
thus it explodes.
	
>How-To-Repeat:
Hop on your nearest alpha and cd comms/kermit && make
	
>Fix:
Three additional patches:

--- ckuus5.c.orig	Thu Jun 18 04:32:48 1998
+++ ckuus5.c	Thu Jun 18 05:00:44 1998
@@ -2540,4 +2540,6 @@
 		q[i] = m_arg[maclvl][i];
-	    debug(F111,"popclvl mac 8",
-		  (maclvl > -1 && macx[maclvl]) ? macx[maclvl] : "",maclvl);
+		if (maclvl > -1 && macx[maclvl])
+		    debug(F111,"popclvl mac 8",macx[maclvl],maclvl);
+		else
+		    debug(F111,"popclvl mac 8","",maclvl);
 	} else maclvl = -1;

--- ckutio.c.orig	Thu Jun 18 05:04:33 1998
+++ ckutio.c	Thu Jun 18 05:12:25 1998
@@ -7178,3 +7178,3 @@
     clock_storage = time(
-#ifdef IRIX60
+#if defined(IRIX60) || defined(__NetBSD__)
 			 (time_t *)
@@ -7184,3 +7184,7 @@
 			 0 );
+#ifdef __NetBSD__
+    *s = ctime( (time_t *)&clock_storage );
+#else
     *s = ctime( &clock_storage );
+#endif
     debug(F110,"ztime: ATTSV",*s,0);

--- ckufio.c.orig	Thu Jun 18 05:15:10 1998
+++ ckufio.c	Thu Jun 18 05:19:26 1998
@@ -2961,6 +2961,14 @@
 	}
+#ifdef __NetBSD__
+	time_stamp = localtime((time_t *)&tmx);
+#else
 	time_stamp = localtime(&tmx);
+#endif
 	if (!time_stamp)
 	  return(-1);
+#ifdef __NetBSD__
+	if (localtime((time_t *)&tmx)->tm_isdst)
+#else
 	if (localtime(&tmx)->tm_isdst)
+#endif
 	  tmx -= 60L * 60L;		/* Adjust for daylight savings time */


	
>Audit-Trail:
>Unformatted: