Subject: port-mac68k/6613: missing #ifdef ALTXBUTTONS in aed.c
To: None <gnats-bugs@gnats.netbsd.org>
From: None <kei_sun@ba2.so-net.ne.jp>
List: netbsd-bugs
Date: 12/20/1998 03:03:56
>Number: 6613
>Category: port-mac68k
>Synopsis: missing #ifdef ALTXBUTTONS in aed.c
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: gnats-admin (GNATS administrator)
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Dec 19 10:20:01 1998
>Last-Modified:
>Originator: SUNAGAWA Keiki
>Organization:
individual
>Release: -current source SUP'ed in 1998/12/16
>Environment:
NetBSD/mac68k 1.3I
>Description:
mac68k/dev/aed.c has a line using ADBK_3 not enclosed with
#ifdef ALTXBUTTONS. It probably breaks on non-US keyboard.
>How-To-Repeat:
I don't know about this option, but some people said it was
incompatible with non-US keyboard.
>Fix:
apply the diff below.
Index: aed.c
===================================================================
RCS file: /cvsroot/src/sys/arch/mac68k/dev/aed.c,v
retrieving revision 1.1.1.1
retrieving revision 1.1.1.1.2.1
diff -u -r1.1.1.1 -r1.1.1.1.2.1
--- aed.c 1998/12/16 00:05:55 1.1.1.1
+++ aed.c 1998/12/17 02:29:47 1.1.1.1.2.1
@@ -244,7 +244,9 @@
aed_handoff(&new_event);
break;
case ADBK_KEYUP(ADBK_RIGHT):
+#ifdef ALTXBUTTONS
case ADBK_KEYUP(ADBK_3):
+#endif
aed_sc->sc_buttons &= ~4; /* right up */
new_event.def_addr = ADBADDR_MS;
new_event.u.m.buttons = aed_sc->sc_buttons;
>Audit-Trail:
>Unformatted: