>Number:         6869
>Category:       bin
>Synopsis:       ld.elf_so/Makefile has private definition of includes target
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 24 14:35:00 1999
>Last-Modified:
>Originator:     Erik Bertelsen
>Organization:
	
>Release:        NetBSD-current 24 Jan 1999
>Environment:
	
System: NetBSD rlanarh108.uni-c.dk 1.3I NetBSD 1.3I (HJEMME) #9: Sun Jan 24 16:36:16 GMT 1999 erik@rlanarh108.uni-c.dk:/home/src/sys/arch/macppc/compile/HJEMME macppc


>Description:
	I have observed that the Makefile for libexec/ld.elf_so has its own implementation of
	the includes target instead of using the one from bsd.inc.mk. Unless there is a reason
	for this, I suggest a fix along the lines of the patch below.

	regards
	Erik Bertelsen

	PS: you may also consider changing the assignment of link.h via HDRS to INCS to a
	direct assignment to INCS in libexec/ld.aout_so/Makefile, while you are in the
	neighbourhood...
>How-To-Repeat:
>Fix:
Index: Makefile
===================================================================
RCS file: /home/cvs-base/src/libexec/ld.elf_so/Makefile,v
retrieving revision 1.1.1.19
diff -c -r1.1.1.19 Makefile
*** Makefile	1999/01/11 15:09:44	1.1.1.19
--- Makefile	1999/01/24 22:21:37
***************
*** 29,35 ****
  
  .if (${OBJECT_FMT} == "ELF")
  # to be installed
! HDRS=	link.h
  .endif
  
  STRIPFLAG=
--- 29,36 ----
  
  .if (${OBJECT_FMT} == "ELF")
  # to be installed
! INCS=	link.h
! INCSDIR=/usr/include
  .endif
  
  STRIPFLAG=
***************
*** 39,52 ****
  ${PROG}: ${OBJS} ${DPADD}
  	${LD} ${LDFLAGS} -o ${PROG} ${OBJS} ${LDADD}
  
- includes:
- 	@cd ${.CURDIR}; for i in $(HDRS); do \
- 	    j="cmp -s $$i ${DESTDIR}/usr/include/$$i || \
- 	    ${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m 444 $$i \
- 		${DESTDIR}/usr/include"; \
- 	    echo $$j; \
- 	    eval "$$j"; \
- 	done
  .endif
  
  NOMAN=
--- 40,45 ----
>Audit-Trail:
>Unformatted: