Subject: lib/7038: doesn't __RENAME() things that need it
To: None <gnats-bugs@gnats.netbsd.org>
From: None <tv@pobox.com>
List: netbsd-bugs
Date: 02/23/1999 07:53:53
>Number:         7038
>Category:       lib
>Synopsis:       <sys/signal.h> doesn't __RENAME() things that need it
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    lib-bug-people (Library Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 23 05:05:01 1999
>Last-Modified:
>Originator:     Todd Vierling
>Organization:
	DuhNet: Pointing out the obvious since 1994.
>Release:        -current as of mid-Feb.
>Environment:

>Description:

Seen in a recent pkgsrc commit:

pkgsrc/net/netatalk/patches/patch-ax (ADDED)
pkgsrc/net/netatalk/patches/patch-ay (ADDED)
pkgsrc/net/netatalk/patches/patch-az (ADDED)
pkgsrc/net/netatalk/patches/patch-ba (ADDED)
pkgsrc/net/netatalk/patches/patch-bb (ADDED)
    (wrstuden - Tue Feb 23 00:31:41 UTC 1999)
    Add patches to include signal.h rather than sys/signal.h. Fixes sudden-
    deaths observed with afpd. From Jim Wise, jwise@netbsd.org.

How far are we going to go to bend over backwards for all this admittedly
broken software?  Are we *really* going to rely on linker warnings to get
everyone to fix third-party code not in pkgsrc?  We went through this--and
it became quite obvious that leaving it as-is would create more headaches
than it would help.

>How-To-Repeat:

Compile something that includes <sys/signal.h> and not <signal.h>

>Fix:

Move the __RENAME()s to <sys/signal.h>.  Protect them by _POSIX_SOURCE and
the like if desired, and if so, duplicate them in <signal.h>.

Leaving them as-is for 1.4 is NOT acceptable.
>Audit-Trail:
>Unformatted: