>Number:         7336
>Category:       port-i386
>Synopsis:       missing VERSIONFILE in i386 dosboot, netboot Makefiles
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    port-i386-maintainer (NetBSD/i386 Portmaster)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr  7 14:20:01 1999
>Last-Modified:
>Originator:     John Darrow
>Organization:
Computing Services, Wheaton College, Wheaton, IL
>Release:        NetBSD 1.4_ALPHA
>Environment:
System: NetBSD jdarrow.wheaton.edu 1.4_ALPHA NetBSD 1.4_ALPHA (JDARROW) #1: Mon Apr 5 22:24:15 CDT 1999 jdarrow@jdarrow.wheaton.edu:/var/src/sys/arch/i386/compile/JDARROW i386

>Description:
While performing a build today, I noticed that the Makefiles in 
sys/arch/i386/stand/dosboot and .../netboot are missing the
VERSIONFILE= ${.CURDIR}/version line found in .../biosboot/Makefile.
This causes (non-fatal) errors in the newvers.sh command run as part
of the build process, as, since ${.ALLSRC} isn't defined, the newvers.sh
tries to use the string "DOS Boot" (or "Network Boot") as the version
file name.  This then causes the version strings in vers.c to be
incorrect.

Simply adding the line to these files fixes the problem.

(Note that, though netboot isn't currently built by default, the line
should still be added for consistency).

>How-To-Repeat:
	cd /sys/arch/i386/stand; make
	notice "head: DOS: no such file or directory" errors
	examine Makefiles

>Fix:
Index: sys/arch/i386/stand/dosboot/Makefile
===================================================================
RCS file: /source/cvs/netbsd/current/src/sys/arch/i386/stand/dosboot/Makefile,v
retrieving revision 1.1.1.2
retrieving revision 1.2
diff -c -r1.1.1.2 -r1.2
*** Makefile	1999/02/25 22:40:07	1.1.1.2
--- Makefile	1999/04/07 20:13:11	1.2
***************
*** 26,29 ****
--- 26,31 ----
  SAMISCMAKEFLAGS= SA_USE_CREAD=yes SA_INCLUDE_NET=no
  I386MISCMAKEFLAGS= I386_INCLUDE_DOS=yes
  
+ VERSIONFILE= ${.CURDIR}/version
+ 
  .include "../Makefile.booters"
Index: sys/arch/i386/stand/netboot/Makefile
===================================================================
RCS file: /source/cvs/netbsd/current/src/sys/arch/i386/stand/netboot/Makefile,v
retrieving revision 1.1.1.3
retrieving revision 1.2
diff -c -r1.1.1.3 -r1.2
*** Makefile	1999/02/25 22:40:17	1.1.1.3
--- Makefile	1999/04/07 20:13:12	1.2
***************
*** 67,72 ****
--- 67,74 ----
  #I386MISCCPPFLAGS+= -DSUPPORT_SERIAL -DDIRECT_SERIAL -DCOMCONS_KEYPRESS
  I386MISCMAKEFLAGS= I386_INCLUDE_DISK=no I386_INCLUDE_BUS=yes
  
+ VERSIONFILE= ${.CURDIR}/version
+ 
  .include "../Makefile.booters"
  
  conf.o dev_net.o: Makefile
>Audit-Trail:
>Unformatted: