Subject: Re: kern/8638: make build fails due to loadfile_machdep.h is missing in INCS in Makefile
To: SUNAGAWA Keiki <kei_sun@ba2.so-net.ne.jp>
From: Chris G. Demetriou <cgd@netbsd.org>
List: netbsd-bugs
Date: 10/17/1999 13:58:07
SUNAGAWA Keiki <kei_sun@ba2.so-net.ne.jp> writes:
> >How-To-Repeat:
> 	make build fails on sys/lib/libsa/loadfile.c.  log file are such:
> 
> (snip)
> In file included from /a/anoncvs/netbsd/src/sys/arch/macppc/stand/ofwboot/../../../../lib/libsa/loadfile.c:94:
> /a/anoncvs/netbsd/src/sys/arch/macppc/stand/ofwboot/../../../../lib/libsa/loadfile.h:70: machine/loadfile_machdep.h: No such file or directory
> mkdep: compile failed.
> *** Error code 1
> (snip)

Is this a bug?  Why are the boot blocks building using the installed
headers.

They shouldn't be.

> >Fix:
> 	following patch fixed compilation problem on macppc, but alpha, bebox,
> 	newsmips also lack loadfile_machdep.h in INCS in their
> 	include/Makefile.

And indeed, unless i'm mistaken, all of these should lack it.  8-)

Take a look at the Alpha boot blocks for an example of the right
patch.


> 	In addition to that, rbus_machdep.h which were introduced recently with
> 	CardBus (currently i386 and macppc) are also missing.

Again, why should those be exported to user-land.  in general, if
things are not needed by userland, they should not be exported to
userland.

The whole point of the 'make includes' changes to the kernel was so
that kernel-only headers wouldn't have to be exported to user-land.


cgd
-- 
Chris Demetriou - cgd@netbsd.org - http://www.netbsd.org/People/Pages/cgd.html
Disclaimer: Not speaking for NetBSD, just expressing my own opinion.