Subject: kern/9151: buglet in hd64570.c (leads to kernel build error)
To: None <gnats-bugs@gnats.netbsd.org>
From: Patrick Welche <prlw1@cam.ac.uk>
List: netbsd-bugs
Date: 01/09/2000 06:57:53
>Number: 9151
>Category: kern
>Synopsis: #ifdef ISO missing in hd64570.c
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: kern-bug-people (Kernel Bug People)
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Jan 9 06:57:00 2000
>Last-Modified:
>Originator: Patrick Welche
>Organization:
>Release: 9 January 2000 approx 12:00 GMT
>Environment:
NetBSD/i386-current
>Description:
If ISO not defined, unused variable llc will cause an error which because
of -Werror will cause an irritation.
>How-To-Repeat:
Compile a kernel without ISO
>Fix:
Index: hd64570.c
===================================================================
RCS file: /cvsroot/syssrc/sys/dev/ic/hd64570.c,v
retrieving revision 1.9
diff -c -r1.9 hd64570.c
*** hd64570.c 2000/01/08 20:46:29 1.9
--- hd64570.c 2000/01/09 14:48:07
***************
*** 793,799 ****
--- 793,801 ----
struct sockaddr *dst;
struct rtentry *rt0;
{
+ #ifdef ISO
struct hdlc_llc_header *llc;
+ #endif
struct hdlc_header *hdlc;
struct ifqueue *ifq;
int s, error;
***************
*** 1513,1519 ****
--- 1515,1523 ----
{
struct ifqueue *ifq;
struct hdlc_header *hdlc;
+ #ifdef ISO
struct hdlc_llc_header *llc;
+ #endif
struct cisco_pkt *cisco;
sca_desc_t *desc;
struct mbuf *m;
>Audit-Trail:
>Unformatted: