Subject: Re: kern/10207: ADEV_CDROM does nothing
To: Gregory McGarry <g.mcgarry@ieee.org>
From: Manuel Bouyer <bouyer@antioche.lip6.fr>
List: netbsd-bugs
Date: 05/29/2000 10:12:00
On Mon, May 29, 2000 at 07:52:43AM +1000, Gregory McGarry wrote:
> It is a SCSI device.  The only place ADEV_CDROM is currently being
> used is in scsiconf.c.  It looks like the original ADEV_CDROM entry
> was introduced at:
> 
> revision 1.129
> date: 1999/10/10 18:49:15;  author: hwr;  state: Exp;  lines: +3 -1
> Add a quirk to recognize a Toshiba XM-3401TA SCSI CD-ROM as
> removable SCSI device. From Matthew Fredette <fredette@mit.edu> in
> kern/7438.
> 
> If ADEV_CDROM should not be used, what is the correct way to handle
> these quirk entries?

Initially I added this for ATAPI devices (it's also why it was not handled for
the SCSI case). If it's also used for SCSI devices
it should be renamed to SDEV_CDROM (yes, it's mostly cosmetic :)

--
Manuel Bouyer, LIP6, Universite Paris VI.           Manuel.Bouyer@lip6.fr
--