Subject: lib/10773: src/lib/checkver must be executable
To: None <gnats-bugs@gnats.netbsd.org>
From: None <g.mcgarry@ieee.org>
List: netbsd-bugs
Date: 08/07/2000 01:24:12
>Number:         10773
>Category:       lib
>Synopsis:       build fails if src/lib/checkver does not have executable permissions
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Aug 07 01:25:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Gregory McGarry
>Release:        1.5_ALPHA <NetBSD-current source date>
>Organization:
	-- Gregory McGarry <g.mcgarry@ieee.org>
>Environment:

>Description:

src/lib/checkver must have executable permissions otherwise the build
will fail.  Surprisingly, it appears to have been like this for quite
some time.

I don't know if there is any policy on having executables in the source
tree...

>How-To-Repeat:

Remove executable permission from src/lib/checkver (or mount noexec) and
attempt a build.

>Fix:

Follow precedent set by src/distrib/sets:

--- sharesrc/share/mk/bsd.lib.mk.orig   Mon Aug  7 18:06:44 2000
+++ sharesrc/share/mk/bsd.lib.mk        Mon Aug  7 18:07:13 2000
@@ -26,7 +26,7 @@
        exists(${BSDSRCDIR}/lib/checkver)
 checkver:
        @(cd ${.CURDIR} && \
-               ${BSDSRCDIR}/lib/checkver -v ${SHLIB_VERSION_FILE} \
+               sh ${BSDSRCDIR}/lib/checkver -v ${SHLIB_VERSION_FILE} \
                    -d ${DESTDIR}${LIBDIR} ${LIB})
 .endif
 .endif
--- basesrc/lib/checkvers.orig  Mon Aug  7 18:20:20 2000
+++ basesrc/lib/checkvers       Mon Aug  7 18:20:33 2000
@@ -182,7 +182,7 @@
     # here, whether given to us or built, so always
     # pass the -f flag.
     (cd `dirname $f` ;
-    "$EXECDIR"/checkver $QUIET -f "$LIBLIST" "$LIBNAME" ;
+    "sh $EXECDIR"/checkver $QUIET -f "$LIBLIST" "$LIBNAME" ;
     exit $?)
     ERR=$?
     if [ $ERR -eq 2 ] ; then
>Release-Note:
>Audit-Trail:
>Unformatted: