Subject: pkg/10890: rsync daemon doesn't work on 1.5
To: None <gnats-bugs@gnats.netbsd.org>
From: None <bouyer@antioche.lip6.fr>
List: netbsd-bugs
Date: 08/24/2000 04:21:15
>Number:         10890
>Category:       pkg
>Synopsis:       rsync daemon doesn't work on 1.5
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 24 04:22:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        1.5_ALPHA2, -current pkgsrc
>Organization:

LIP6, Universite Paris VI.

>Environment:
	
System: NetBSD armandeche 1.5_ALPHA2 NetBSD 1.5_ALPHA2 (ARMANDECHE) #0: Wed Aug 23 19:04:34 MEST 2000 bouyer@armandeche:/home/NetBSD-1.5/src/sys/arch/i386/compile/ARMANDECHE i386


>Description:
	rsync daemon (started with rsync --daemon or from inetd) doesn't work
	on 1.5, client gets "link_stat  : No such file or directory" or
	"push_dir rsyncd: No such file or directory (3)". For the first case
	I tracked this down to and empty string being passed to argv[0]
	in send_file_list(). The second is also from do_server_sender(),
	looks like in the --daemon case we should use argv++.
	But I suspect the root cause is the same. The really, really strange
	thing is that the exact same pkgsrc works fine on a 1.4.2 system,
	as does the 1.4.2 binary on a 1.5 system.

>How-To-Repeat:
	Have a 1.4.2 rsync public server, try to upgrade to 1.5_ALPHA.
>Fix:
	workaround: use 1.4.2 package in COMPAT_14.
	Although it works on 1.4 and not 1.5 I suspect a bug in rsync,
	probably reading out of an array bound. I don't have the time
	to track this more yet.
>Release-Note:
>Audit-Trail:
>Unformatted: