Subject: bin/11158: inconsistent tab/spacing in m4 [w/PATCH]
To: None <gnats-bugs@gnats.netbsd.org>
From: None <nrahlstr@winternet.com>
List: netbsd-bugs
Date: 10/07/2000 12:25:11
>Number: 11158
>Category: bin
>Synopsis: inconsistent tab/spacing in m4 [w/PATCH]
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: bin-bug-people
>State: open
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sat Oct 07 12:25:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator: Nathan Ahlstrom <nrahlstr@winternet.com>
>Release: NetBSD-current from 23-Sept-2000
>Organization:
My House
>Environment:
System: NetBSD games 1.5G NetBSD 1.5G (NRA) #0: Sat Oct 7 07:45:02 CDT 2000 root@games:/b/NetBSD-sys/src/sys/arch/i386/compile/NRA i386
>Description:
Minor formatting issues in usr.bin/m4.
The attached patch remedies the inconsistency.
Index: eval.c
===================================================================
RCS file: /a/projects/NetBSD-CVS/basesrc/usr.bin/m4/eval.c,v
retrieving revision 1.11
diff -u -u -r1.11 eval.c
--- eval.c 1999/04/20 08:05:51 1.11
+++ eval.c 2000/10/07 19:14:50
@@ -433,17 +433,17 @@
}
pbstr(argv[2]);
break;
- case '@':
- for (n = argc - 1; n > 2; n--) {
- pbstr(rquote);
- pbstr(argv[n]);
- pbstr(lquote);
+ case '@':
+ for (n = argc - 1; n > 2; n--) {
+ pbstr(rquote);
+ pbstr(argv[n]);
+ pbstr(lquote);
putback(COMMA);
- }
+ }
pbstr(rquote);
- pbstr(argv[2]);
+ pbstr(argv[2]);
pbstr(lquote);
- break;
+ break;
default:
putback(*p);
putback('$');
Index: expr.c
===================================================================
RCS file: /a/projects/NetBSD-CVS/basesrc/usr.bin/m4/expr.c,v
retrieving revision 1.9
diff -u -u -r1.9 expr.c
--- expr.c 1999/04/14 09:38:37 1.9
+++ expr.c 2000/10/07 19:15:56
@@ -520,10 +520,10 @@
ndig++;
}
ungetch();
-
+
if (ndig == 0)
experr("bad constant");
-
+
return rval;
}
>How-To-Repeat:
>Fix:
See above patch. The lines in question used spaces instead tabs.
>Release-Note:
>Audit-Trail:
>Unformatted: