Subject: pkg/11185: Can't disable sound in xlockmore
To: None <gnats-bugs@gnats.netbsd.org>
From: Mark Davies <mark@MCS.VUW.AC.NZ>
List: netbsd-bugs
Date: 10/10/2000 03:01:16
>Number:         11185
>Category:       pkg
>Synopsis:       Can't disable sound in xlockmore
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 10 03:01:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Mark Davies
>Release:        4/9/2000
>Organization:
Dept. of Comp. Sci., Victoria Uni. of Wellington, New Zealand.
>Environment:
	
System: NetBSD turakirae.mcs.vuw.ac.nz 1.5E NetBSD 1.5E (MCS_WORKSTATION) #1: Mon Sep 4 14:16:09 NZST 2000 mark@turakirae.mcs.vuw.ac.nz:/src/work/src/sys/arch/i386/compile/MCS_WORKSTATION i386


>Description:
	If the esound package has been installed then xlock from the xlockmore
	package always plays sounds even if disabled in resources or on command
	line.

>How-To-Repeat:
	Install esound package.
	Install xlockmore package.
	run "xlock" or explicitly "xlock +sound" and note you get sounds.

>Fix:
	Add the following as an additional patch to the xlockmore package

--- xlock/xlock.c~	Tue Oct 10 14:36:32 2000
+++ xlock/xlock.c	Tue Oct 10 15:27:31 2000
@@ -3086,7 +3086,7 @@
 #endif
 
 #if defined( USE_SOUND ) && defined( USE_ESOUND )
-        sound =( init_sound() != -1 );
+        sound = sound && ( init_sound() != -1 );
 #endif
 
 #ifdef USE_DTSAVER

	


cheers
mark
>Release-Note:
>Audit-Trail:
>Unformatted: