>Number:         11955
>Category:       pkg
>Synopsis:       syntax error in netatalk INSTALL script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 14 08:17:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Jim Bernard
>Release:        January 13, 2001
>Organization:
Speaking for myself
>Environment:
System: NetBSD zoo 1.5E NetBSD 1.5E (ZOO-$Revision: 1.55 $) #0: Sat Aug 12 14:34:20 MDT 2000 jim@zoo:/home/tmp/compile/sys/arch/i386/compile/ZOO i386


>Description:
	Installation of net/netatalk package is incomplete because of a
	syntax error in the pkg/INSTALL script.  The problem is an if
	statement using test in the form of "[" that is missing a space
	before the closing bracket:
	  if [ ! -f ${ETCDIR}/${file} -a -f ${PKG_PREFIX}/etc/${file}]
	should be:
	  if [ ! -f ${ETCDIR}/${file} -a -f ${PKG_PREFIX}/etc/${file} ]

>How-To-Repeat:
	Try to install netatalk.  Note error messages in output:
	  [: missing]
	  [: missing]
	  [: missing]
	  [: missing]

>Fix:
--- INSTALL-dist	Wed Jul 26 13:03:23 2000
+++ INSTALL	Sun Jan 14 08:58:34 2001
@@ -23,11 +23,11 @@
 			AppleVolumes.default \
 			AppleVolumes.system \
 			atalkd.conf \
 			papd.conf
 		do
-			if [ ! -f ${ETCDIR}/${file} -a -f ${PKG_PREFIX}/etc/${file}]
+			if [ ! -f ${ETCDIR}/${file} -a -f ${PKG_PREFIX}/etc/${file} ]
 			then
 				echo "  ${ETCDIR}/${file}"
 				cp ${PKG_PREFIX}/etc/${file} ${ETCDIR}/${file}
 				chmod 644 ${ETCDIR}/${file}
 			fi
>Release-Note:
>Audit-Trail:
>Unformatted: