Subject: kern/12500: struct atapi_flex_geometry_page tweak
To: None <gnats-bugs@gnats.netbsd.org>
From: Brett McCoy <bmccoy@morte.piffle.net>
List: netbsd-bugs
Date: 03/29/2001 12:32:56
>Number:         12500
>Category:       kern
>Synopsis:       add missing field definitions to struct atapi_flex_geometry_page
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 29 09:34:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Brett McCoy
>Release:        2001-03-29
>Organization:
	
>Environment:
	
System: NetBSD morte 1.5T NetBSD 1.5T (MORTEfw) #71: Thu Mar 29 11:33:24 EST 2001 bmccoy@morte:/usr/src/sys/arch/i386/compile/MORTEfw i386
Architecture: i386
Machine: i386
>Description:
	struct atapi_flex_geometry_page is missing the "motor off delay" byte
	and the last 2 reserved bytes of the block.  The "motor off delay" byte
	is currently consumed by the reserved1 array.

	This isn't currently a problem since nothing appears to use or want
	this data, but it's part of the standard and should be included for
	completeness.
>How-To-Repeat:
	
>Fix:
	
Index: atapi_disk.h
===================================================================
RCS file: /cvsroot/syssrc/sys/dev/scsipi/atapi_disk.h,v
retrieving revision 1.3
diff -u -r1.3 atapi_disk.h
--- atapi_disk.h        1998/02/13 08:28:21     1.3
+++ atapi_disk.h        2001/03/29 17:26:49
@@ -80,8 +80,11 @@
        u_int8_t ph_sec_tr;             /* physical sectors per track */
        u_int8_t blklen[2];             /* block length (bytes per sector) */
        u_int8_t ncyl[2];               /* number of cylinders */
-       u_int8_t reserved1[18];
+       u_int8_t reserved1[10];
+       u_int8_t motor_off_dly;
+       u_int8_t reserved2[7];
        u_int8_t rot_rate[2];           /* medium rotation rate (RPM) */
+       u_int8_t reserved3[2];
 };
 
 #define ATAPI_FLEX_GEOMETRY_PAGE       0x05
>Release-Note:
>Audit-Trail:
>Unformatted: