>Number:         13224
>Category:       pkg
>Synopsis:       audio/musicbox fails to build with xpkgwedge
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 15 18:51:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     John Darrow
>Release:        NetBSD/i386 1.5.1_BETA2 20010602; pkgsrc 20010607
>Organization:
Computing Services, Wheaton College, Wheaton, IL
>Environment:
NetBSD rebekah.wheaton.edu 1.5.1_BETA2 NetBSD 1.5.1_BETA2 (REBEKAH) #0: Thu Jun  7 06:19:18 CDT 2001     jdarrow@michal.wheaton.edu:/var/src/sys/arch/i386/compile/REBEKAH i386


>Description:
After the Makefile for audio/musicbox goes to the trouble of doing an
EVAL_PREFIX for QT1DIR, patch-aa blatantly ignores this setting,
and assumes qt1 is in X11BASE.  This causes a build failure if qt1 was
built with xpkgwedge.

From bulk build:

[...]
===> Building for musicbox-1.01p2
moc player.h -o mplayer.cpp
gcc -c mplayer.cpp -o mplayer.o -DNetBSD -I/usr/X11R6/include -I/usr/X11R6/qt1/i
nclude
In file included from mplayer.cpp:16:
player.h:4: qwidget.h: No such file or directory
player.h:5: qlistbox.h: No such file or directory
player.h:6: qlabel.h: No such file or directory
player.h:7: qpopmenu.h: No such file or directory
In file included from player.h:8,
                 from mplayer.cpp:16:
ListView.h:4: qlistbox.h: No such file or directory
ListView.h:5: qpainter.h: No such file or directory
ListView.h:6: qpixmap.h: No such file or directory
ListView.h:7: qstrlist.h: No such file or directory
ListView.h:8: qpopmenu.h: No such file or directory
ListView.h:9: qlined.h: No such file or directory
ListView.h:10: qlabel.h: No such file or directory
In file included from player.h:8,
                 from mplayer.cpp:16:
ListView.h:12: qdialog.h: No such file or directory
In file included from ListView.h:13,
                 from player.h:8,
                 from mplayer.cpp:16:
MultiListBox.h:3: qtablevw.h: No such file or directory
MultiListBox.h:4: qwidget.h: No such file or directory
MultiListBox.h:5: qpixmap.h: No such file or directory
MultiListBox.h:6: qlist.h: No such file or directory
In file included from player.h:9,
                 from mplayer.cpp:16:
clock.h:5: qlcdnum.h: No such file or directory
clock.h:6: qdatetm.h: No such file or directory
mplayer.cpp:17: qmetaobject.h: No such file or directory
*** Error code 1

Stop.
*** Error code 1

Stop.
*** Error code 1

Stop.
*** Error code 1

Stop.
BULK> musicbox-1.01p2 was marked as broken:
-rw-r--r--  1 root  wheel  4700 Jun  9 14:23 .broken

>How-To-Repeat:
( cd audio/musicbox && make package ) with xpkgwedge installed

>Fix:
Replace patch-aa with the new patch below, and rebuild distinfo.
(The change replaces X11BASE/qt1 with QT1DIR/qt1 in INC and LIB.)

$NetBSD: patch-aa,v 1.4 2000/03/28 00:09:21 dmcmahill Exp $

--- Makefile.orig	Wed Nov 12 14:01:58 1997
+++ Makefile	Sun Mar 26 11:00:40 2000
@@ -1,13 +1,17 @@
 # change following for your environment
-INC = /usr/X11R6/include/X11/qt
-LIB = /usr/X11R6/lib
+#INC = /usr/X11R6/include/X11/qt
+INC = -I${X11BASE}/include -I${QT1DIR}/qt1/include
+LIB = -L${QT1DIR}/qt1/lib -Wl,-R${QT1DIR}/qt1/lib -L${X11BASE}/lib -Wl,-R${X11BASE}/lib
 MOC = moc
 
 # if you use freebsd
-CFLAGS = -DFreeBSD
+#CFLAGS = -DFreeBSD
 
 #if you use linux
 #CFLAGS = -DLinux
 
+# if you use netbsd
+CFLAGS = -DNetBSD
+
 GCC = gcc
 
@@ -19,11 +23,11 @@
 
 all:	${ALL}
-	${GCC} ${ALL} -o ${PKG} -L${LIB} -I${INC} -lqt
+	${GCC} ${ALL} -o ${PKG} ${LIB}  -lqt -lX11 -lXext -lossaudio
 
-player.o:
-	${GCC} -c player.cpp -o player.o ${CFLAGS} -L${LIB} -I${INC}
+player.o: player.cpp
+	${GCC} -c player.cpp -o player.o ${CFLAGS} ${INC}
 
 mplayer.o: mplayer.cpp
-	${GCC} -c mplayer.cpp -o mplayer.o ${CFLAGS} -L${LIB} -I${INC}
+	${GCC} -c mplayer.cpp -o mplayer.o ${CFLAGS} ${INC}
 
 mplayer.cpp:
@@ -31,13 +35,13 @@
 
 ListView.o:
-	${GCC} -c ListView.cpp -o ListView.o ${CFLAGS} -L${LIB} -I${INC} 
+	${GCC} -c ListView.cpp -o ListView.o ${CFLAGS} ${INC} 
 
 mListView.o: mListView.cpp
-	${GCC} -c mListView.cpp -o mListView.o ${CFLAGS} -L${LIB} -I${INC}
+	${GCC} -c mListView.cpp -o mListView.o ${CFLAGS} ${INC}
 
 mListView.cpp:
 	${MOC} ListView.h -o mListView.cpp
 clock.o:
-	${GCC} -c clock.cpp -o clock.o -L${LIB} -I${INC}
+	${GCC} -c clock.cpp -o clock.o ${INC}
 
 mclock.cpp:
@@ -45,5 +49,5 @@
 
 mclock.o: mclock.cpp
-	${GCC} -c mclock.cpp -o mclock.o -L${LIB} -I${INC}
+	${GCC} -c mclock.cpp -o mclock.o ${INC}
 
 mfilebrowse.cpp: 
@@ -51,14 +55,14 @@
 
 filebrowse.o :
-	${GCC} -c filebrowse.cpp -o filebrowse.o -L${LIB} -I${INC}
+	${GCC} -c filebrowse.cpp -o filebrowse.o ${INC}
 
 mfilebrowse.o: mfilebrowse.cpp
-	${GCC} -c mfilebrowse.cpp -o mfilebrowse.o -L${LIB} -I${INC}
+	${GCC} -c mfilebrowse.cpp -o mfilebrowse.o ${INC}
 
 diskbrowse.o:
-	${GCC} -c diskbrowse.cpp -o $@ -L${LIB} -I${INC}
+	${GCC} -c diskbrowse.cpp -o $@ ${INC}
 
 mdiskbrowse.o: mdiskbrowse.cpp
-	${GCC} -c mdiskbrowse.cpp -o $@ -L${LIB} -I${INC}
+	${GCC} -c mdiskbrowse.cpp -o $@ ${INC}
 
 mdiskbrowse.cpp:
@@ -66,8 +70,8 @@
 
 qktstreelist.o:
-	${GCC} -c qktstreelist.cpp -o $@ -L${LIB} -I${INC}
+	${GCC} -c qktstreelist.cpp -o $@ ${INC}
 
 mqktstreelist.o: mqktstreelist.cpp
-	${GCC} -c mqktstreelist.cpp -o $@ -L${LIB} -I${INC}
+	${GCC} -c mqktstreelist.cpp -o $@ ${INC}
 
 mqktstreelist.cpp:
@@ -75,5 +79,5 @@
 
 MultiListBox.o:
-	${GCC} -c MultiListBox.cpp -o $@ -L${LIB} -I${INC}
+	${GCC} -c MultiListBox.cpp -o $@ ${INC}
 	
 mMultiListBox.cpp:
@@ -81,5 +85,5 @@
 
 mMultiListBox.o: mMultiListBox.cpp
-	${GCC} -c mMultiListBox.cpp -o $@ -L${LIB} -I${INC}
+	${GCC} -c mMultiListBox.cpp -o $@ ${INC}
 
 clean:
>Release-Note:
>Audit-Trail:
>Unformatted: