Subject: kern/13725: Indentation wrong in wi.c
To: None <gnats-bugs@gnats.netbsd.org>
From: seebs <seebs@ged.plethora.net>
List: netbsd-bugs
Date: 08/15/2001 16:18:19
>Number: 13725
>Category: kern
>Synopsis: Indentation doesn't follow KNF
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Aug 15 14:15:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator: seebs
>Release: 8/12 or so
>Organization:
>Environment:
System: NetBSD ged.plethora.net 1.5X NetBSD 1.5X (GED) #29: Mon Aug 13 21:16:14 CDT 2001 seebs@ged.plethora.net:/usr/src/sys/arch/i386/compile/GED i386
Architecture: i386
Machine: i386
>Description:
The switch in wi_get_id is not correctly indented; the case labels
are indented from the switch, and KNF says case labels line up with
the switch.
>How-To-Repeat:
Read driver.
>Fix:
This is a sort of stupid diff, but it captures the intent.
1675,1710c1675,1710
< case WI_NIC_EVB2:
< printf("RF:PRISM2 MAC:HFA3841");
< sc->sc_prism2 = 1;
< break;
< case WI_NIC_HWB3763:
< printf("RF:PRISM2 MAC:HFA3841 CARD:HWB3763 rev.B");
< sc->sc_prism2 = 1;
< break;
< case WI_NIC_HWB3163:
< printf("RF:PRISM2 MAC:HFA3841 CARD:HWB3163 rev.A");
< sc->sc_prism2 = 1;
< break;
< case WI_NIC_HWB3163B:
< printf("RF:PRISM2 MAC:HFA3841 CARD:HWB3163 rev.B");
< sc->sc_prism2 = 1;
< break;
< case WI_NIC_EVB3:
< printf("RF:PRISM2 MAC:HFA3842");
< sc->sc_prism2 = 1;
< break;
< case WI_NIC_HWB1153:
< printf("RF:PRISM1 MAC:HFA3841 CARD:HWB1153");
< sc->sc_prism2 = 1;
< break;
< case WI_NIC_P2_SST:
< printf("RF:PRISM2 MAC:HFA3841 CARD:HWB3163-SST-flash");
< sc->sc_prism2 = 1;
< break;
< case WI_NIC_PRISM2_5:
< printf("RF:PRISM2.5 MAC:ISL3873");
< sc->sc_prism2 = 1;
< break;
< default:
< printf("Lucent chip or unknown chip\n");
< sc->sc_prism2 = 0;
< break;
---
> case WI_NIC_EVB2:
> printf("RF:PRISM2 MAC:HFA3841");
> sc->sc_prism2 = 1;
> break;
> case WI_NIC_HWB3763:
> printf("RF:PRISM2 MAC:HFA3841 CARD:HWB3763 rev.B");
> sc->sc_prism2 = 1;
> break;
> case WI_NIC_HWB3163:
> printf("RF:PRISM2 MAC:HFA3841 CARD:HWB3163 rev.A");
> sc->sc_prism2 = 1;
> break;
> case WI_NIC_HWB3163B:
> printf("RF:PRISM2 MAC:HFA3841 CARD:HWB3163 rev.B");
> sc->sc_prism2 = 1;
> break;
> case WI_NIC_EVB3:
> printf("RF:PRISM2 MAC:HFA3842");
> sc->sc_prism2 = 1;
> break;
> case WI_NIC_HWB1153:
> printf("RF:PRISM1 MAC:HFA3841 CARD:HWB1153");
> sc->sc_prism2 = 1;
> break;
> case WI_NIC_P2_SST:
> printf("RF:PRISM2 MAC:HFA3841 CARD:HWB3163-SST-flash");
> sc->sc_prism2 = 1;
> break;
> case WI_NIC_PRISM2_5:
> printf("RF:PRISM2.5 MAC:ISL3873");
> sc->sc_prism2 = 1;
> break;
> default:
> printf("Lucent chip or unknown chip\n");
> sc->sc_prism2 = 0;
> break;
>Release-Note:
>Audit-Trail:
>Unformatted: