Subject: port-sparc64/13811: PCITAG_SETNODE() is defined using `x' insted of `t'.
To: None <gnats-bugs@gnats.netbsd.org>
From: None <ura@hiru.aoba.yokohama.jp>
List: netbsd-bugs
Date: 08/28/2001 23:37:35
>Number: 13811
>Category: port-sparc64
>Synopsis: PCITAG_SETNODE() is defined using `x' insted of `t'.
>Confidential: no
>Severity: critical
>Priority: low
>Responsible: port-sparc64-maintainer
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Aug 28 07:33:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator: URA Hiroshi
>Release: NetBSD-current (2001/08/27)
>Organization:
>Environment:
>Description:
PCITAG_SETNODE() is defined using `x' insted of `t'.
but PCITAG_SETNODE() isn't used.
>How-To-Repeat:
see sys/arch/sparc64/include/pci_machdep.h
>Fix:
--- sys/arch/sparc64/include/pci_machdep.h.orig Sat Jul 21 01:13:28 2001
+++ sys/arch/sparc64/include/pci_machdep.h Tue Aug 28 23:25:06 2001
@@ -67,7 +67,7 @@
#define PCITAG_NODE(x) (int)(((x)>>32)&0xffffffff)
#define PCITAG_OFFSET(x) ((x)&0xffffffff)
#define PCITAG_CREATE(n,b,d,f) (((u_int64_t)(n)<<32)|((b)<<16)|((d)<<11)|((f)<<8))
-#define PCITAG_SETNODE(t,n) ((x)&0xffffffff)|(((n)<<32)
+#define PCITAG_SETNODE(t,n) ((t)&0xffffffff)|(((n)<<32)
typedef u_int64_t pcitag_t;
>Release-Note:
>Audit-Trail:
>Unformatted: