Subject: pkg/13958: squsq(1) source tidbit
To: SEND-PR <gnats-bugs@gnats.netbsd.org>
From: Don Yuniskis <auryn@gci-net.com>
List: netbsd-bugs
Date: 09/15/2001 14:32:14
>Number: 13958
>Category: pkg
>Synopsis: squsq(1) lossage in use of #ifdef preprocessor directive
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: pkg-manager
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Sep 15 14:38:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator: Don Yuniskis
>Release: NetBSD 1.5.1
>Organization:
Don Yuniskis
>Environment:
System: NetBSD Itsy.Bitsy.Micro 1.5.1 NetBSD 1.5.1 (GENERIC) #56: Mon Jul 2
15:54:23 CEST 2001 he@nsa.uninett.no:/usr/src/sys/arch/i386/compile/GENERIC
i386
>Description:
Apparent confusion in use of #ifdef preprocessor directive.
Does not affect binary built (at least not on i386!). Fix
cleans up compiler warning.
>How-To-Repeat:
Examine sources
>Fix:
Apply patch...
*** usq.c.old Sun Sep 9 06:59:13 2001
--- usq.c Sun Sep 9 07:01:32 2001
***************
*** 215,221 ****
goto closein;
}
! #ifdef C70 | TOPS20
filecrc = getx16(inbuff);
#else
filecrc = getw16(inbuff);
--- 215,221 ----
goto closein;
}
! #if defined(C70) | defined(TOPS20)
filecrc = getx16(inbuff);
#else
filecrc = getw16(inbuff);
***************
*** 239,245 ****
printf("%s -> %s: ", infile, outfile);
#endif
! #ifdef C70 | TOPS20
numnodes = getx16(inbuff);
#else
numnodes = getw16(inbuff);
--- 239,245 ----
printf("%s -> %s: ", infile, outfile);
#endif
! #if defined(C70) | defined(TOPS20)
numnodes = getx16(inbuff);
#else
numnodes = getw16(inbuff);
>Release-Note:
>Audit-Trail:
>Unformatted:
X-send-pr-version: 3.95