>Number:         14092
>Category:       pkg
>Synopsis:       [PATCH] STRIP used instead of STRIPFLAG in sysutils/lsof/Makefile
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 28 19:35:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Eric Gillespie Jr.
>Release:        NetBSD 1.5.1
>Organization:
>Environment:
System: NetBSD trantor.pretzelnet.org 1.5.2 NetBSD 1.5.2 (TRANTOR) #0: Sun Sep 23 03:08:13 EST 2001 epg@trantor.pretzelnet.org:/u/src/sys/arch/i386/compile/TRANTOR i386


>Description:
The Makefile for sysutils/lsof contains the following line:

	${INSTALL} ${COPY} ${STRIP} -o ${BINOWN} -g ${BINGRP} -m 2755 ${REAL_GROUP} \

If you look at /usr/share/mk/bsd.{README,own.mk,prog.mk,sys.mk} you'll
see that STRIPFLAG is to be used with install and defaults to -s, while
STRIP is to be used as the strip command and defaults to strip.  I have
the following in /etc/mk.conf to prevent any binaries from being stripped:

STRIPFLAG=
STRIP=/usr/bin/true

This fails because the lsof Makefile passes ${STRIP} to install instead
of ${STRIPFLAG}

>How-To-Repeat:
Set STRIP and STRIPFLAG in /etc/mk.conf to values similar to the above.
>Fix:
Apply this patch to sysutils/lsof/Makefile:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/lsof/Makefile,v
retrieving revision 1.45
diff -a -u -r1.45 Makefile
--- Makefile	2001/08/21 09:51:56	1.45
+++ Makefile	2001/09/29 02:05:28
@@ -51,7 +51,7 @@
 	@( cd ${WRKSRC} ; ${ECHO} "y" | ./Inventory || exit 1 )
 
 do-install:
-	${INSTALL} ${COPY} ${STRIP} -o ${BINOWN} -g ${BINGRP} -m 2755 ${REAL_GROUP} \
+	${INSTALL} ${COPY} ${STRIPFLAG} -o ${BINOWN} -g ${BINGRP} -m 2755 ${REAL_GROUP} \
 		${WRKSRC}/lsof ${PREFIX}/sbin
 	${INSTALL_MAN} ${WRKSRC}/lsof.man ${PREFIX}/man/man1/lsof.1
 	@${INSTALL_DATA_DIR} ${PREFIX}/share/lsof
>Release-Note:
>Audit-Trail:
>Unformatted: