>Number:         15345
>Category:       bin
>Synopsis:       MD5-hash password pullup broke 1-5-branch build
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 23 09:06:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     windsor@warthog.com
>Release:        NetBSD 1.5.3_ALPHA
>Organization:
nose-pickers anonymous
>Environment:
System: NetBSD dasher 1.5.3_ALPHA NetBSD 1.5.3_ALPHA (DASHER) #35: Tue Jan 22 12:24:43 CST 2002 windsor@dasher:/usr/src/sys/arch/i386/compile/DASHER i386
Architecture: i386
Machine: i386
>Description:
dependall ===> libcrypt
mkdep -a crypt.c md5crypt.c
lint -chapbxzF  -i crypt.c
crypt.c(315): warning: bitwise operation on signed value possibly nonportable
crypt.c(493): _PASSWORD_NONDES undefined
crypt.c(520): warning: pointer casts may be troublesome
crypt.c(521): warning: pointer casts may be troublesome
[...]
crypt.c(966): warning: bitwise operation on signed value possibly nonportable
*** Error code 1

Stop.

>How-To-Repeat:
	try to build 1.5 branch.
>Fix:
	apply following patch to basesrc:

--- include/pwd.h.FCS	Wed Jan 23 10:53:55 2002
+++ include/pwd.h	Wed Jan 23 10:54:29 2002
@@ -63,6 +63,7 @@
 #define	_PW_KEYBYUID		'3'	/* stored by uid */
 
 #define	_PASSWORD_EFMT1		'_'	/* extended encryption format */
+#define	_PASSWORD_NONDES	'$'	/* non-DES encryption formats */
 
 #define	_PASSWORD_LEN		128	/* max length, not counting NUL */
 
>Release-Note:
>Audit-Trail:
>Unformatted: