Subject: port-mac68k/15528: Flaw in disklabel editor in mac68k/sysinstall
To: None <gnats-bugs@gnats.netbsd.org>
From: Frederick Bruckman <fredb@immanent.net>
List: netbsd-bugs
Date: 02/07/2002 08:44:31
>Number:         15528
>Category:       port-mac68k
>Synopsis:       Flaw in disklabel editor in mac68k/sysinstall
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    port-mac68k-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 07 06:45:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Frederick Bruckman
>Release:        NetBSD 1.5ZA
>Organization:

Frederick
>Environment:
	
N/A

>Description:
	
	There's a logic flaw in the part of sysinstall that tries to
	anticipate how the kernel disklabel code will interpret the
	new, not-yet-written, label. HFS and FFS partitions are each
	chosen from the same pool, without regard to whether or not
	one of the other type has taken the letter. This means, that
	if you make two HFS partitons and two FFS partitions, the
	second of each will be assigned "d". Since this is not how the
	kernel does it, you can end up newfs'ing the wrong partition.

>How-To-Repeat:
>Fix:
	
	What it should rather do, is make two passes: the first
	assigns all the partitions which have preferred assignments --
	a to Root, b to Swap, g to Root & Usr, the second pass should
	assign the remaining partitions to the remaining slots, in the
	order they're found on the disk, just like the kernel does.
>Release-Note:
>Audit-Trail:
>Unformatted: