Subject: kern/16306: erroneous (but temporarily harmless) variable type error
To: None <gnats-bugs@gnats.netbsd.org>
From: None <smb@research.att.com>
List: netbsd-bugs
Date: 04/11/2002 14:21:35
>Number: 16306
>Category: kern
>Synopsis: A 16-bit variable is presumed to hold 17 bits
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Thu Apr 11 11:22:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Steven M. Bellovin
>Release: NetBSD 1.5.3_RC1
>Organization:
AT&T Labs Research
>Environment:
System: NetBSD berkshire.research.att.com 1.5.3_RC1 NetBSD 1.5.3_RC1 (BERKSHIRE.nosound) #0: Sat Mar 30 14:17:24 EST 2002 smb@berkshire.research.att.com:/usr/src/sys/arch/i386/compile/BERKSHIRE.nosound i386
Architecture: i386
Machine: i386
>Description:
There appears (to me, and I could easily be missing something) a bug in
scsipiconf.h in 1.5.3. It now defines PQUIRK_NOBIGMODESENSE, but it
has it as 0x10000 when the variable 'quirks' is declared u_int16.
It's not a big problem here, since the only thing using PQUIRK_NOBIGMODESENSE
in my source tree is for the M-Systems Disk-on-Key, and the changes for
it weren't pulled up (hint, hint). But I think the definition should
be changed before anyone else tries to use it.
>How-To-Repeat:
>Fix:
Change the declaration of 'quirk' to 'int' or 'u_int32'.
>Release-Note:
>Audit-Trail:
>Unformatted: