>Number:         16415
>Category:       pkg
>Synopsis:       mail/faces-1.6.1nb1 fs2ikon script does not work with graphics/netpbm-9.25 and other faces bugs...
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 19 14:40:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Greg A. Woods
>Release:        pkgsrc-2002/04/02
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD 1.5W
Architecture: i386
Machine: i386
>Description:

	there are several bugs in the mail/faces-1.6.1nb1 package:

	- it seems the fs2ikon script was not tested with netpbm-9.25 installed

	- there may be other scripts not tested with netpbm-9.25 installed

	- the package does not have a runtime dpendency registered for
	  graphics/netpbm

	- there are probably other dependencies that should be
	  registered, including perl (there's on perl script)

	- the do-configure target should probably use make's .for (and
	  appropriate make macro modifiers) instead of a shell 'for' loop

>How-To-Repeat:

	install mail/faces and graphics/netpbm and try to figure out how
	to convert a 48x48 GIF image into a format suitable for compface.

>Fix:

	this patch fixes the fs2ikon script, at least for the case where
	the image is already 48x48 pixels, but maybe it should instead
	use pnmscale?

--- /usr/pkg/bin/fs2ikon	Wed Apr 17 23:51:24 2002
+++ ./fs2ikon	Fri Apr 19 00:13:29 2002
@@ -26,14 +26,14 @@
     y=$2
     if [ $x -ge $y ]
     then
-	ppmscale -width 48 $file.pgm | ppmtopgm | pgmtopbm > $file.pbm
+	ppmtopgm < $file.pgm | pgmtopbm > $file.pbm
 	set `sed -n -e 2p -e 2q $file.pbm`
 	yo=`expr '(' 48 - $2 ')' / 2`
 	pbmmake 48 48 |
 	    pnmpaste $file.pbm 0 $yo |
 	    pbmtoicon 
     else
-	ppmscale -height 48 $file.pgm | ppmtopgm | pgmtopbm > $file.pbm
+	ppmtopgm < $file.pgm | pgmtopbm > $file.pbm
 	set `sed -n -e 2p -e 2q $file.pbm`
 	xo=`expr '(' 48 - $1 ')' / 2`
 	pbmmake 48 48 |
@@ -43,7 +43,6 @@
 	sed -e 1,2d -e '20s/$/,/' |
 	tr -d '\011\012' |
 	tr ',' '\012' |
-	sed -e 's/^/0x/' |
 	pr -l1 -t -w22 -3 -s, |
 	sed -e 's/$/,/' > $file.face
     rm $file.pbm
>Release-Note:
>Audit-Trail:
>Unformatted: