Subject: port-i386/17387: i386 installboot error messages need improvement
To: None <gnats-bugs@gnats.netbsd.org>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 06/25/2002 13:05:23
>Number: 17387
>Category: port-i386
>Synopsis: i386 installboot error messages need improvement
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: port-i386-maintainer
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Jun 25 11:54:02 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Greg A. Woods
>Release: NetBSD-current 2002/06/23
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD
Architecture: i386
Machine: i386
>Description:
the installboot error messages complain about problems without
giving the details necessary to fix those problems...
>How-To-Repeat:
>Fix:
this same kind of fix should probably be made for other
architectures too....
Index: installboot.c
===================================================================
RCS file: /cvs/master/m-NetBSD/main/syssrc/sys/arch/i386/stand/installboot/installboot.c,v
retrieving revision 1.15
diff -c -c -r1.15 installboot.c
*** installboot.c 10 Sep 1999 16:45:27 -0000 1.15
--- installboot.c 25 Jun 2002 17:00:44 -0000
***************
*** 196,202 ****
/* need new entry */
if (fraglist->numentries > fraglist->maxentries - 1) {
! errx(1, "not enough fragment space in bootcode\n");
return (-1);
}
--- 196,204 ----
/* need new entry */
if (fraglist->numentries > fraglist->maxentries - 1) {
! errx(1, "not enough fragment space in bootcode: need %d, max %d\n",
! fraglist->numentries,
! fraglist->maxentries);
return (-1);
}
***************
*** 338,344 ****
printf("%s: block number %d, size %u table blocks: %d/%d\n",
diskdev, blkno, size, ndb, fraglist->maxentries);
if (ndb > fraglist->maxentries) {
! errx(1, "not enough fragment space in bootcode\n");
return (-1);
}
--- 340,347 ----
printf("%s: block number %d, size %u table blocks: %d/%d\n",
diskdev, blkno, size, ndb, fraglist->maxentries);
if (ndb > fraglist->maxentries) {
! errx(1, "not enough fragment space in bootcode, need %d more\n",
! ndb - fraglist->maxentries);
return (-1);
}
>Release-Note:
>Audit-Trail:
>Unformatted: