>Number:         18041
>Category:       pkg
>Synopsis:       patch: xmms requires libiconv to decode ogg vorbis comments
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 22 08:54:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        NetBSD 1.6_RC1
>Organization:
	
>Environment:
	
	
System: NetBSD wubba.CS.Princeton.EDU 1.6_RC1 NetBSD 1.6_RC1 (WUBBA) #2: Tue Aug 20 12:15:41 EDT 2002 richards@wubba.CS.Princeton.EDU:/home/richards/kern i386
Architecture: i386
Machine: i386
>Description:
	
	Ogg Vorbis comment metadata is encoded in UTF-8. The present
	xmms package lacks a dependency on libiconv, so vorbis
	comments with diacritics etc. show up as garbage.
>How-To-Repeat:
	<code/input/activities to reproduce the problem (multiple
lines)>
	Choose the "view file info" menu option on a vorbis file with
	non-ascii characters in the comment data.
>Fix:
	
	Patch follows.

diff -u pkgsrc/audio/xmms/Makefile pkgsrc/audio/xmms.iconv/Makefile
--- pkgsrc/audio/xmms/Makefile	Thu Aug  8 12:17:06 2002
+++ pkgsrc/audio/xmms.iconv/Makefile	Thu Aug 22 11:34:57 2002
@@ -27,6 +27,11 @@
 CONFIGURE_ARGS+=	--with-dev-dsp=/dev/sound
 CPPFLAGS+=		-DHAVE_NANOSLEEP=1
 
+# Broken configure script assumes that iconv_open lives in libc; work around.
+CPPFLAGS+=		-DHAVE_ICONV_OPEN=1
+CONFIGURE_ENV+=		ac_cv_func_iconv_open=yes
+LIBS+=			-liconv
+
 .if (${MACHINE_ARCH} == i386)
 post-patch:
 .if (${OBJECT_FMT} == a.out)
@@ -42,6 +47,7 @@
 .include "../../audio/libmikmod/buildlink.mk"
 .include "../../audio/libvorbis/buildlink.mk"
 .include "../../graphics/Mesa/buildlink.mk"
+.include "../../converters/libiconv/buildlink.mk"
 .include "../../textproc/libxml/buildlink.mk"
 .include "../../x11/gtk/buildlink.mk"
 .include "../../mk/ossaudio.buildlink.mk"
>Release-Note:
>Audit-Trail:
>Unformatted: