>Number:         18914
>Category:       pkg
>Synopsis:       comms/modemd (attempts to) install into /usr/lib
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 03 22:16:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Robert Elz
>Release:        NetBSD 1.6I (pkgsrc of 2002-11-03)
>Organization:
	Prince of Songkla University
>Environment:
	
	
System: NetBSD fuchsia.cs.mu.OZ.AU 1.6I NetBSD 1.6I (FUCHSIA) #23: Tue Oct 15 01:40:03 ICT 2002 kre@fuchsia.cs.mu.OZ.AU:/usr/obj/sys/FUCHSIA i386
Architecture: i386
Machine: i386
>Description:
	When doing a "make install" (incl "make package", etc) in
	comms/modemd the file libmodemd.a will be installed into
	/usr/lib (or an attempt will be made to do that, running with
	/usr mounted read only prevents this kind of error)

	This seems to be a by-product of changes to bsd.lib.mk when the
	new "libinstall" target was created (replacing install)
>How-To-Repeat:
	pkg_delete modemd-970221 >/dev/null 2>&1
	cd pkgsrc/comms/modemd
	make install
	ls -l /usr/lib/libmodemd*
>Fix:
	Apply the patch appended in comms/modemd

	It adds (an empty) libinstall target to override the one in
	bsd.lib.mk (the library is not intended to be installed).
	The install target is left, so this continues to work properly
	on older versions of NetBSD (before the bsd.lib.mk changes).

	I believe binary packages will be fine, as the stray file was
	not in any PLIST, it shouldn't he been included there, so anyone
	who installed this package from a binary package hs no problem.
	Anyone who has installed modemd from pkgsrc should be advised
	(somehow) that they should go and manually delete /usr/lib/libmodemd.a

	The patch below patches patch/patch-aa (can I fit the word patch
	into that line any more times??) and distinfo to account for that.

	Don't forget to delete the .orig files that patch will leave behind
	(though I guess a "cvs commit" would ignore them anyway).

--- patches/patch-aa.WAS	Fri Aug  7 17:36:44 1998
+++ patches/patch-aa	Mon Nov  4 08:22:54 2002
@@ -1,8 +1,8 @@
 $NetBSD: patch-aa,v 1.2 1998/08/07 10:36:44 agc Exp $
 
---- common/Makefile.orig	Tue Sep 10 02:11:06 1996
-+++ common/Makefile	Tue Mar  3 17:41:28 1998
-@@ -3,8 +3,11 @@
+--- common/Makefile.orig	Tue Sep 10 07:11:06 1996
++++ common/Makefile	Mon Nov  4 08:17:59 2002
+@@ -3,8 +3,13 @@
  LIB=modemd
  # Don't need a profiled library...
  NOPROFILE=
@@ -12,6 +12,8 @@
 +CPPFLAGS += -I${.CURDIR}/.. -I${.CURDIR}/../include
 +
 +install:
++
++libinstall:
  
  .include "../Makefile.inc"
  .include <bsd.lib.mk>
--- distinfo.WAS	Fri Apr 20 16:04:23 2001
+++ distinfo	Mon Nov  4 08:23:25 2002
@@ -2,7 +2,7 @@
 
 SHA1 (modemd-970221.tar.gz) = 104f8e596f711e349203b2da8c4f2ecf40d490c3
 Size (modemd-970221.tar.gz) = 56093 bytes
-SHA1 (patch-aa) = fdd18e77e89127af6fc150f4ade9b4e3224a2579
+SHA1 (patch-aa) = 312b55c2c365cefb2d81ae24780931d2f607df6b
 SHA1 (patch-ab) = 8afeab67a4715d7f6ed553dee5c82d442120876d
 SHA1 (patch-ac) = 2f87a347c6723179da84379ced6f6ad83d412708
 SHA1 (patch-ad) = e8c78c84b9ab58644d8e2e105416d5ef5b59fba4
>Release-Note:
>Audit-Trail:
>Unformatted: